fix(auth): let ServiceFailureException bubble up for proper HTTP status mapping during auth #2670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
singhpk234
previously approved these changes
Sep 25, 2025
runtime/service/src/test/java/org/apache/polaris/service/auth/AuthenticatingAugmentorTest.java
Outdated
Show resolved
Hide resolved
singhpk234
approved these changes
Sep 25, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
github-project-automation
bot
moved this from Done
to PRs In Progress
in Basic Kanban Board
github-project-automation
bot
moved this from PRs In Progress
to Done
in Basic Kanban Board
Contributor
|
Thanks @HotSushi for the fix! Thanks @singhpk234 @HonahX for the review. |
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Nov 20, 2025
* Minio testcontainer: allow setting a specific region (apache#2664) ... to remove the need to derive it via the AWS-SDK default mechanism requiring a system property or environment variable. * fix(deps): update dependency org.apache.commons:commons-lang3 to v3.19.0 (apache#2665) * Doc: Add breaking changes section for 1.1 release (apache#2654) * fix(deps): update dependency com.h2database:h2 to v2.4.240 (apache#2668) * fix(auth): let ServiceFailureException bubble up for proper HTTP status mapping during auth (apache#2670) * fix(deps): update immutables to v2.11.4 (apache#2679) * fix(deps): update dependency com.diffplug.spotless:spotless-plugin-gradle to v8 (apache#2669) * chore(deps): update quay.io/keycloak/keycloak docker tag to v26.3.5 (apache#2681) * Last merged commit 2c0bf58 --------- Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: Prashant Singh <35593236+singhpk234@users.noreply.github.com> Co-authored-by: Sushant Raikar <sushant.raikar+OSS@snowflake.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, ServiceFailureException from persistence layer timeouts was being
wrapped in AuthenticationFailedException, causing IOException during loadEntity
operations to return 401 Unauthorized instead of the correct 503 Service Unavailable.
This change allows ServiceFailureException to bubble up to IcebergExceptionMapper
which properly maps it to 503 Service Unavailable, while preserving the existing
behavior for other authentication exceptions.
Tests
✅ Added a unit test
✅
./gradlew buildsucceeds