From 1d2c9e5d59880ff3db6c300f9b10bc6345f0a1bf Mon Sep 17 00:00:00 2001 From: Prashant Date: Sun, 12 Oct 2025 13:38:34 -0700 Subject: [PATCH 1/3] Fix client generation --- regtests/README.md | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/regtests/README.md b/regtests/README.md index 7a51160b85..6ef68aa777 100644 --- a/regtests/README.md +++ b/regtests/README.md @@ -187,19 +187,25 @@ Python tests are based on `pytest`. They rely on a python Polaris client, which The client can be generated using two commands: ```shell -# generate the management api client +# Management client docker run --rm \ - -v ${PWD}:/local openapitools/openapi-generator-cli generate \ + -v ${PWD}:/local openapitools/openapi-generator-cli:v7.9.0 generate \ -i /local/spec/polaris-management-service.yml \ -g python \ - -o /local/client/python --additional-properties=packageName=polaris.management --additional-properties=apiNamePrefix=polaris + -o /local/client/python \ + --additional-properties=packageName=polaris.management \ + --additional-properties=apiNamePrefix=polaris -# generate the iceberg rest client +# IRC client docker run --rm \ - -v ${PWD}:/local openapitools/openapi-generator-cli generate \ + -v ${PWD}:/local openapitools/openapi-generator-cli:v7.9.0 generate \ -i /local/spec/polaris-catalog-service.yaml \ -g python \ - -o /local/client/python --additional-properties=packageName=polaris.catalog --additional-properties=apiNameSuffix="" --additional-properties=apiNamePrefix=Iceberg + -o /local/client/python \ + --additional-properties=packageName=polaris.catalog \ + --additional-properties=apiNameSuffix="" \ + --additional-properties=apiNamePrefix=Iceberg + ``` Tests rely on Python 3.9 or higher. `pyenv` can be used to install a current version and mapped to the local directory From c2c2b28c68b770a042dc51daaf0c26fbc8d8dd6c Mon Sep 17 00:00:00 2001 From: Prashant Date: Sun, 12 Oct 2025 19:58:53 -0700 Subject: [PATCH 2/3] Address feedback --- regtests/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/regtests/README.md b/regtests/README.md index 6ef68aa777..b45e1195f7 100644 --- a/regtests/README.md +++ b/regtests/README.md @@ -187,7 +187,7 @@ Python tests are based on `pytest`. They rely on a python Polaris client, which The client can be generated using two commands: ```shell -# Management client +# generate the management api client docker run --rm \ -v ${PWD}:/local openapitools/openapi-generator-cli:v7.9.0 generate \ -i /local/spec/polaris-management-service.yml \ @@ -196,7 +196,7 @@ docker run --rm \ --additional-properties=packageName=polaris.management \ --additional-properties=apiNamePrefix=polaris -# IRC client +# generate the management api client docker run --rm \ -v ${PWD}:/local openapitools/openapi-generator-cli:v7.9.0 generate \ -i /local/spec/polaris-catalog-service.yaml \ From c46ab2c52b661b444cb8ec9b84d89d5d21e7d699 Mon Sep 17 00:00:00 2001 From: Prashant Date: Mon, 13 Oct 2025 06:08:20 -0700 Subject: [PATCH 3/3] fix typo and address review feedback --- regtests/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/regtests/README.md b/regtests/README.md index b45e1195f7..1b93be38a4 100644 --- a/regtests/README.md +++ b/regtests/README.md @@ -196,7 +196,7 @@ docker run --rm \ --additional-properties=packageName=polaris.management \ --additional-properties=apiNamePrefix=polaris -# generate the management api client +# generate the Polaris catalog api client docker run --rm \ -v ${PWD}:/local openapitools/openapi-generator-cli:v7.9.0 generate \ -i /local/spec/polaris-catalog-service.yaml \