From 78ecaf0358e44723fe99b6de20527bfd688feb42 Mon Sep 17 00:00:00 2001 From: Yong Date: Sun, 2 Nov 2025 12:44:12 -0600 Subject: [PATCH 1/2] Fix findings with codespell --- CONTRIBUTING.md | 2 +- getting-started/spark/notebooks/SparkPolaris.ipynb | 2 +- helm/polaris/templates/_helpers.tpl | 4 ++-- .../service/it/test/PolarisRestCatalogIntegrationBase.java | 2 +- persistence/nosql/idgen/README.md | 2 +- .../spark/v3.5/getting-started/notebooks/SparkPolaris.ipynb | 2 +- .../org/apache/polaris/spark/quarkus/it/SparkDeltaIT.java | 2 +- .../org/apache/polaris/spark/utils/PolarisCatalogUtils.java | 2 +- .../org/apache/polaris/core/auth/PolarisAuthorizerImpl.java | 2 +- .../polaris/core/config/BehaviorChangeConfiguration.java | 2 +- .../apache/polaris/core/config/PolarisConfiguration.java | 2 +- .../java/org/apache/polaris/core/entity/CatalogEntity.java | 4 ++-- .../java/org/apache/polaris/core/entity/PolarisEntity.java | 2 +- .../apache/polaris/core/persistence/BasePersistence.java | 6 +++--- .../transactional/AbstractTransactionalPersistence.java | 4 ++-- .../core/policy/TransactionalPolicyMappingPersistence.java | 2 +- .../apache/polaris/core/persistence/BaseResolverTest.java | 2 +- regtests/t_pyspark/src/test_spark_sql_s3_with_privileges.py | 2 +- runtime/admin/src/main/docker/Dockerfile.jvm | 2 +- runtime/admin/src/main/resources/application.properties | 6 +++--- runtime/defaults/src/main/resources/application.properties | 6 +++--- runtime/server/src/main/docker/Dockerfile.jvm | 2 +- runtime/server/src/main/resources/application.properties | 2 +- .../apache/polaris/service/admin/PolarisAdminService.java | 2 +- .../polaris/service/catalog/iceberg/IcebergCatalog.java | 2 +- .../apache/polaris/service/admin/PolarisAuthzTestBase.java | 2 +- .../generic/PolarisGenericTableCatalogHandlerAuthzTest.java | 2 +- .../catalog/iceberg/IcebergCatalogHandlerAuthzTest.java | 6 +++--- .../catalog/policy/PolicyCatalogHandlerAuthzTest.java | 2 +- .../polaris/service/test/TestEnvironmentExtension.java | 2 +- .../blog/2025/09/19/apache-polaris-1.1.0-incubating.md | 2 +- site/content/in-dev/unreleased/generic-table.md | 2 +- site/content/in-dev/unreleased/managing-security/_index.md | 2 +- .../managing-security/external-idp/idp-dev-notes.md | 2 +- spec/polaris-management-service.yml | 2 +- 35 files changed, 46 insertions(+), 46 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a5ce12247c..dbacefaa59 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -123,7 +123,7 @@ Tips: The Apache Polaris build currently requires Java 21 or later. There are a few tools that help you running the right Java version: -* [SDKMAN!](https://sdkman.io/) follow the installation instructions, then run `sdk list java` to see the available distributions and versions, then run `sdk install java ` using the identifier for the distribution and version (>= 21) of your choice. +* [SDKMAN!](https://sdkman.io/) follow the installation instructions, then run `sdk list java` to see the available distributions and versions, then run `sdk install java ` using the identifier for the distribution and version (>= 21) of your choice. * [jenv](https://www.jenv.be/) If on a Mac you can use jenv to set the appropriate SDK. ## Code Contribution Guidelines diff --git a/getting-started/spark/notebooks/SparkPolaris.ipynb b/getting-started/spark/notebooks/SparkPolaris.ipynb index 4eb04a7c58..11d190f941 100644 --- a/getting-started/spark/notebooks/SparkPolaris.ipynb +++ b/getting-started/spark/notebooks/SparkPolaris.ipynb @@ -638,7 +638,7 @@ "metadata": {}, "source": [ "# Add another Principal Role to the Engineer Principal\n", - "A principal can belong to multiple Principal Roles. Typically, a call will use the union of all privilages assigned to all of the principal's roles. " + "A principal can belong to multiple Principal Roles. Typically, a call will use the union of all privileges assigned to all of the principal's roles. " ] }, { diff --git a/helm/polaris/templates/_helpers.tpl b/helm/polaris/templates/_helpers.tpl index 447e8e9e10..03369b320b 100644 --- a/helm/polaris/templates/_helpers.tpl +++ b/helm/polaris/templates/_helpers.tpl @@ -157,7 +157,7 @@ line breaks, they will be escaped and a multi-line option will be printed. Escapes a property key to be used in a configmap, conforming with the Java parsisng rules for property files: https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/Properties.html#load(java.io.Reader) - Escapes all backslashes. -- Escapes all key termination charaters: '=', ':' and whitespace. +- Escapes all key termination characters: '=', ':' and whitespace. */}} {{- define "polaris.escapeConfigOptionKey" -}} {{- $key := . -}} @@ -204,7 +204,7 @@ Converts a Kubernetes quantity to a number (int64 if possible or float64 otherwi It handles raw numbers as well as quantities with suffixes like m, k, M, G, T, P, E, ki, Mi, Gi, Ti, Pi, Ei. It also handles scientific notation. -Quantities should be positive, so negative values, zero, or any unparseable number +Quantities should be positive, so negative values, zero, or any unparsable number will result in a failure. https://kubernetes.io/docs/reference/kubernetes-api/common-definitions/quantity/ */}} diff --git a/integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationBase.java b/integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationBase.java index f82efc9236..2220229699 100644 --- a/integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationBase.java +++ b/integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationBase.java @@ -1028,7 +1028,7 @@ public void multipleDiffsAgainstMultipleTablesLastFails() { Transaction t2Transaction = catalog().loadTable(identifier2).newTransaction(); t2Transaction.updateSchema().renameColumn("data", "new-column").commit(); - // delete the colum that is being renamed in the above TX to cause a conflict + // delete the column that is being renamed in the above TX to cause a conflict table2.updateSchema().deleteColumn("data").commit(); Schema updatedSchemaTwo = table2.schema(); diff --git a/persistence/nosql/idgen/README.md b/persistence/nosql/idgen/README.md index 576a983cf1..2c04728f0c 100644 --- a/persistence/nosql/idgen/README.md +++ b/persistence/nosql/idgen/README.md @@ -42,7 +42,7 @@ Node IDs are leased by every "JVM running Polaris" for a period of time. The ID that no IDs will be generated for a timestamp that exceeds the "lease time". Leases can be extended. The implementation leverages atomic database operations (CAS) for the lease implementation. -ID generators must not use timestamps before or after the lease period nor must they re-use an older timestamp. This +ID generators must not use timestamps before or after the lease period nor must they reuse an older timestamp. This requirement is satisfied using a monotonic clock implementation. ## Code structure diff --git a/plugins/spark/v3.5/getting-started/notebooks/SparkPolaris.ipynb b/plugins/spark/v3.5/getting-started/notebooks/SparkPolaris.ipynb index 8e2be2918e..69e7f34316 100644 --- a/plugins/spark/v3.5/getting-started/notebooks/SparkPolaris.ipynb +++ b/plugins/spark/v3.5/getting-started/notebooks/SparkPolaris.ipynb @@ -399,7 +399,7 @@ " id int, name string)\n", "USING delta LOCATION 'file:///tmp/delta_tables/people';\n", "\"\"\")\n", - "# You can also use cloud storage like s3. For eample: s3:///\n", + "# You can also use cloud storage like s3. For example: s3:///\n", "# Make the corresponding credentials are set up correctly" ] }, diff --git a/plugins/spark/v3.5/integration/src/intTest/java/org/apache/polaris/spark/quarkus/it/SparkDeltaIT.java b/plugins/spark/v3.5/integration/src/intTest/java/org/apache/polaris/spark/quarkus/it/SparkDeltaIT.java index df5b478be8..7beacb1141 100644 --- a/plugins/spark/v3.5/integration/src/intTest/java/org/apache/polaris/spark/quarkus/it/SparkDeltaIT.java +++ b/plugins/spark/v3.5/integration/src/intTest/java/org/apache/polaris/spark/quarkus/it/SparkDeltaIT.java @@ -236,7 +236,7 @@ public void testDataframeSaveOperations() { List subDirs = listDirs(getTableLocation(deltatb)); assertThat(subDirs).contains("_delta_log"); - // verify we can create a table out of the exising delta location + // verify we can create a table out of the existing delta location sql("CREATE TABLE %s USING DELTA LOCATION '%s'", deltatb, getTableLocation(deltatb)); List tables = sql("SHOW TABLES"); assertThat(tables.size()).isEqualTo(1); diff --git a/plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/utils/PolarisCatalogUtils.java b/plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/utils/PolarisCatalogUtils.java index df433ec9fe..d6d9edb576 100644 --- a/plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/utils/PolarisCatalogUtils.java +++ b/plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/utils/PolarisCatalogUtils.java @@ -51,7 +51,7 @@ public static boolean useDelta(String provider) { } /** - * For tables whose location is manged by Spark Session Catalog, there will be no location or path + * For tables whose location is managed by Spark Session Catalog, there will be no location or path * in the properties. */ public static boolean isTableWithSparkManagedLocation(Map properties) { diff --git a/polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizerImpl.java b/polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizerImpl.java index e98f0302a1..489bc4fdae 100644 --- a/polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizerImpl.java +++ b/polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizerImpl.java @@ -865,7 +865,7 @@ public boolean isAuthorized( * permissions matching {@code privilege} on any entity in the resolvedPath of the resolvedPath. * *

The caller is responsible for translating these checks into either behavioral actions (e.g. - * returning 404 instead of 403, checking other root privileges that supercede the checked + * returning 404 instead of 403, checking other root privileges that supersede the checked * privilege, choosing whether to vend credentials) or throwing relevant Unauthorized * errors/exceptions. */ diff --git a/polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java b/polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java index 19f10a2ba0..0a9e5bde3b 100644 --- a/polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java +++ b/polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java @@ -70,7 +70,7 @@ protected BehaviorChangeConfiguration( .key("TABLE_OPERATIONS_MAKE_METADATA_CURRENT_ON_COMMIT") .description( "If true, BasePolarisTableOperations should mark the metadata that is passed into" - + " `commit` as current, and re-use it to skip a trip to object storage to re-construct" + + " `commit` as current, and reuse it to skip a trip to object storage to re-construct" + " the committed metadata again.") .defaultValue(true) .buildBehaviorChangeConfiguration(); diff --git a/polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java b/polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java index 0750f70265..e70d046a46 100644 --- a/polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java +++ b/polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java @@ -174,7 +174,7 @@ public Builder catalogConfig(String catalogConfig) { } /** - * Used to support backwards compatability before there were reserved properties. Usage of this + * Used to support backwards compatibility before there were reserved properties. Usage of this * method should be removed over time. * * @deprecated Use {@link #catalogConfig()} instead. diff --git a/polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java b/polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java index 055ccd8959..40cf1969d6 100644 --- a/polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java +++ b/polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java @@ -274,13 +274,13 @@ public Builder setCatalogType(String type) { } public Builder setDefaultBaseLocation(String defaultBaseLocation) { - // Note that this member lives in the main 'properties' map rather tha internalProperties. + // Note that this member lives in the main 'properties' map rather than internalProperties. properties.put(DEFAULT_BASE_LOCATION_KEY, defaultBaseLocation); return this; } public Builder setReplaceNewLocationPrefixWithCatalogDefault(String value) { - // Note that this member lives in the main 'properties' map rather tha internalProperties. + // Note that this member lives in the main 'properties' map rather than internalProperties. properties.put(REPLACE_NEW_LOCATION_PREFIX_WITH_CATALOG_DEFAULT_KEY, value); return this; } diff --git a/polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisEntity.java b/polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisEntity.java index 1cd4d59473..44f34fa93b 100644 --- a/polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisEntity.java +++ b/polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisEntity.java @@ -36,7 +36,7 @@ * direct members should be added to this class; rather, they should reside in the PolarisBaseEntity * and this class should just contain the relevant builder methods, etc. The intention when using * this class is to use "immutable" semantics as much as possible, for example constructing new - * copies with the Builder pattern when "mutating" fields rather than ever chaing fields in-place. + * copies with the Builder pattern when "mutating" fields rather than directly changing fields in-place. * Currently, code that intends to operate directly on a PolarisBaseEntity may not adhere to * immutability semantics, and may modify the entity in-place. * diff --git a/polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java b/polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java index 4fa60e8c5d..d238e490e0 100644 --- a/polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java +++ b/polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java @@ -72,7 +72,7 @@ public interface BasePersistence extends PolicyMappingPersistence { * or push down the return status enums from PolarisMetaStoreManager into this layer and document * accordingly. * - *

TODO: Change originalEntity to be just the set of members taht participate in conditions, + *

TODO: Change originalEntity to be just the set of members that participate in conditions, * similar to PolarisEntityCore, and make the callsites in BasePolarisCatalog actually plumb * through correctly, in particular for values the PolarisMetaStoreManagerImpl doesn't have access * to such as the original name and parentId in renames. @@ -108,7 +108,7 @@ void writeEntity( *

TODO: Push down the multi-entity commit from PolarisMetaStoreManagerImpl to use this instead * of running single writeEntity actions within a transaction. * - *

TODO: Change originalEntity to be just the set of members taht participate in conditions, + *

TODO: Change originalEntity to be just the set of members that participate in conditions, * similar to PolarisEntityCore, and make the callsites in BasePolarisCatalog actually plumb * through correctly, in particular for values the PolarisMetaStoreManagerImpl doesn't have access * to such as the original name and parentId in renames. @@ -326,7 +326,7 @@ Page loadEntities( /** * Lookup the current entityGrantRecordsVersion for the specified entity. That version is changed - * everytime a grant record is added or removed on a base securable or added to a grantee. + * every time a grant record is added or removed on a base securable or added to a grantee. * * @param callCtx call context * @param catalogId catalog id or NULL_ID diff --git a/polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/AbstractTransactionalPersistence.java b/polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/AbstractTransactionalPersistence.java index 848a8421e5..902e2c8d6a 100644 --- a/polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/AbstractTransactionalPersistence.java +++ b/polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/AbstractTransactionalPersistence.java @@ -245,7 +245,7 @@ public void writeEntities( // safe to use for entityVersion and grantRecordsVersion right now. Once we refactor // the writeEntities[] methods to take something like PolarisEntityCore // for originalEntity and force the callsites such as BasePolarisCatalog to actually - // provide the original values, this will be correct. For now, the API does't support + // provide the original values, this will be correct. For now, the API doesn't support // bulk renames anyways. boolean nameOrParentChanged = originalEntity == null @@ -612,7 +612,7 @@ public void writeEntitiesInCurrentTxn( // safe to use for entityVersion and grantRecordsVersion right now. Once we refactor // the writeEntities[] methods to take something like PolarisEntityCore // for originalEntity and force the callsites such as BasePolarisCatalog to actually - // provide the original values, this will be correct. For now, the API does't support + // provide the original values, this will be correct. For now, the API doesn't support // bulk renames anyways. boolean nameOrParentChanged = originalEntity == null diff --git a/polaris-core/src/main/java/org/apache/polaris/core/policy/TransactionalPolicyMappingPersistence.java b/polaris-core/src/main/java/org/apache/polaris/core/policy/TransactionalPolicyMappingPersistence.java index 398ddb1a16..2a16223071 100644 --- a/polaris-core/src/main/java/org/apache/polaris/core/policy/TransactionalPolicyMappingPersistence.java +++ b/polaris-core/src/main/java/org/apache/polaris/core/policy/TransactionalPolicyMappingPersistence.java @@ -35,7 +35,7 @@ default void writeToPolicyMappingRecordsInCurrentTxn( * Helpers to check conditions for writing new PolicyMappingRecords in current transaction. * *

It should throw a PolicyMappingAlreadyExistsException if the new record conflicts with an - * exising record with same policy type but different policy. + * existing record with same policy type but different policy. * * @param callCtx call context * @param record policy mapping record to write. diff --git a/polaris-core/src/testFixtures/java/org/apache/polaris/core/persistence/BaseResolverTest.java b/polaris-core/src/testFixtures/java/org/apache/polaris/core/persistence/BaseResolverTest.java index 585006f56b..89fd94fcbb 100644 --- a/polaris-core/src/testFixtures/java/org/apache/polaris/core/persistence/BaseResolverTest.java +++ b/polaris-core/src/testFixtures/java/org/apache/polaris/core/persistence/BaseResolverTest.java @@ -102,7 +102,7 @@ public void setupTest() { // polaris call context protected abstract PolarisCallContext callCtx(); - // utility to bootstrap the mata store + // utility to bootstrap the meta store protected abstract PolarisTestMetaStoreManager tm(); // the meta store manager diff --git a/regtests/t_pyspark/src/test_spark_sql_s3_with_privileges.py b/regtests/t_pyspark/src/test_spark_sql_s3_with_privileges.py index 92e405f095..ae1f71c8b3 100644 --- a/regtests/t_pyspark/src/test_spark_sql_s3_with_privileges.py +++ b/regtests/t_pyspark/src/test_spark_sql_s3_with_privileges.py @@ -438,7 +438,7 @@ def test_spark_credentials_can_delete_after_purge(root_client, snowflake_catalog snowman_catalog_client, test_bucket, aws_bucket_base_location_prefix): """ Using snowman, create namespaces and a table. Insert into the table in multiple operations and update existing records - to generate multiple metadata.json files and manfiests. Drop the table with purge=true. Poll S3 and validate all of + to generate multiple metadata.json files and manifests. Drop the table with purge=true. Poll S3 and validate all of the files are deleted. Using the reader principal's credentials verify read access. Validate the reader cannot insert into the table. diff --git a/runtime/admin/src/main/docker/Dockerfile.jvm b/runtime/admin/src/main/docker/Dockerfile.jvm index c6aa9739ec..4a6330ec38 100644 --- a/runtime/admin/src/main/docker/Dockerfile.jvm +++ b/runtime/admin/src/main/docker/Dockerfile.jvm @@ -36,7 +36,7 @@ ENV USER=polaris ENV UID=10000 ENV HOME=/home/polaris -# We make four distinct layers so if there are application changes the library layers can be re-used +# We make four distinct layers so if there are application changes the library layers can be reused COPY --chown=polaris:polaris build/quarkus-app/lib/ /deployments/lib/ COPY --chown=polaris:polaris build/quarkus-app/quarkus-run.jar /deployments/polaris-admin-tool.jar COPY --chown=polaris:polaris build/quarkus-app/app/ /deployments/app/ diff --git a/runtime/admin/src/main/resources/application.properties b/runtime/admin/src/main/resources/application.properties index 393d12094e..29229ebece 100644 --- a/runtime/admin/src/main/resources/application.properties +++ b/runtime/admin/src/main/resources/application.properties @@ -19,7 +19,7 @@ # ---- Build-time configuration ---- # Build-time properties take effect when Quarkus processes java classes -# and creates Polaris jars. These properties cannot be overriden in runtime. +# and creates Polaris jars. These properties cannot be overridden in runtime. # Cf. https://quarkus.io/guides/all-config quarkus.application.name=Apache Polaris Admin Tool (incubating) @@ -53,7 +53,7 @@ quarkus.arc.ignored-split-packages=\ org.apache.polaris.admintool ## Quarkus required setting for third party indexing -# fixed at buildtime +# fixed at build-time quarkus.index-dependency.avro.group-id=org.apache.avro quarkus.index-dependency.avro.artifact-id=avro quarkus.index-dependency.guava.group-id=com.google.guava @@ -65,5 +65,5 @@ quarkus.index-dependency.protobuf.artifact-id=protobuf-java # Set root logging level to WARN to avoid mostly irrelevant Quarkus log messages. # The Admin tool communicates with the user via STDOUT/STDERR quarkus.log.level=WARN -# Prevent the 'The Agroal dependency is present but no JDBC datasources have been defined.' built-time warning. +# Prevent the 'The Agroal dependency is present but no JDBC datasources have been defined.' build-time warning. quarkus.log.category."io.quarkus.agroal.deployment".level=ERROR diff --git a/runtime/defaults/src/main/resources/application.properties b/runtime/defaults/src/main/resources/application.properties index 54c0082733..bda31e9e70 100644 --- a/runtime/defaults/src/main/resources/application.properties +++ b/runtime/defaults/src/main/resources/application.properties @@ -19,7 +19,7 @@ # ---- Build-time configuration ---- # Build-time properties take effect when Quarkus processes java classes -# and creates Polaris jars. These properties cannot be overriden in runtime. +# and creates Polaris jars. These properties cannot be overridden in runtime. # Cf. https://quarkus.io/guides/all-config quarkus.banner.path=/org/apache/polaris/service/banner.txt @@ -89,7 +89,7 @@ quarkus.oidc.tenant-enabled=false # quarkus.oidc.idp1.auth-server-url=https://auth.example.com/realms/polaris2 # quarkus.oidc.idp1.client-id=polaris2 -# quarkus.otel.sdk.disabled is set to `true` by default to avoid spuriour errors about +# quarkus.otel.sdk.disabled is set to `true` by default to avoid spurious errors about # trace collector connections being impossible to establish. This setting can be enabled # at runtime after configuring other OTel properties for proper trace data collection. quarkus.otel.sdk.disabled=true @@ -269,7 +269,7 @@ quarkus.arc.ignored-split-packages=\ org.apache.polaris.admintool ## Quarkus required setting for third party indexing -# fixed at buildtime +# fixed at build-time quarkus.index-dependency.avro.group-id=org.apache.avro quarkus.index-dependency.avro.artifact-id=avro quarkus.index-dependency.guava.group-id=com.google.guava diff --git a/runtime/server/src/main/docker/Dockerfile.jvm b/runtime/server/src/main/docker/Dockerfile.jvm index 84ebee136f..393c9c8a3f 100644 --- a/runtime/server/src/main/docker/Dockerfile.jvm +++ b/runtime/server/src/main/docker/Dockerfile.jvm @@ -36,7 +36,7 @@ ENV USER=polaris ENV UID=10000 ENV HOME=/home/polaris -# We make four distinct layers so if there are application changes the library layers can be re-used +# We make four distinct layers so if there are application changes the library layers can be reused COPY --chown=polaris:polaris build/quarkus-app/lib/ /deployments/lib/ COPY --chown=polaris:polaris build/quarkus-app/*.jar /deployments/ COPY --chown=polaris:polaris build/quarkus-app/app/ /deployments/app/ diff --git a/runtime/server/src/main/resources/application.properties b/runtime/server/src/main/resources/application.properties index 7fb87a7150..cd9d74decc 100644 --- a/runtime/server/src/main/resources/application.properties +++ b/runtime/server/src/main/resources/application.properties @@ -19,7 +19,7 @@ # ---- Build-time configuration ---- # Build-time properties take effect when Quarkus processes java classes -# and creates Polaris jars. These properties cannot be overriden in runtime. +# and creates Polaris jars. These properties cannot be overridden in runtime. # Cf. https://quarkus.io/guides/all-config quarkus.application.name=Apache Polaris Server (incubating) diff --git a/runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java b/runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java index 67ae7ad6e5..44e2d95f1d 100644 --- a/runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java +++ b/runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java @@ -134,7 +134,7 @@ * Namespaces, Tables and Views, abstracted away from Iceberg REST objects, this class represents * the logical model for managing realm-level Catalogs, Principals, Roles, and Grants. * - *

Different API implementors could expose different REST, gRPC, etc., interfaces that delegate + *

Different API implementers could expose different REST, gRPC, etc., interfaces that delegate * to this logical model without being tightly coupled to a single frontend protocol, and can * provide different implementations of PolarisEntityManager to abstract away the implementation of * the persistence layer. diff --git a/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java b/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java index 633bca5f95..d68d4799cf 100644 --- a/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java +++ b/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java @@ -877,7 +877,7 @@ private String applyDefaultLocationObjectStoragePrefix( if (!optimizedSiblingCheck) { throw new IllegalStateException( String.format( - "%s and %s are both disabled, which means that table location overlap checkes are being" + "%s and %s are both disabled, which means that table location overlap checks are being" + " performed, but only within each namespace. However, %s is enabled, which indicates" + " that tables may be created outside of their parent namespace. This is not a safe" + " combination of configurations.", diff --git a/runtime/service/src/test/java/org/apache/polaris/service/admin/PolarisAuthzTestBase.java b/runtime/service/src/test/java/org/apache/polaris/service/admin/PolarisAuthzTestBase.java index 72f3b1a9e4..22794c4f5d 100644 --- a/runtime/service/src/test/java/org/apache/polaris/service/admin/PolarisAuthzTestBase.java +++ b/runtime/service/src/test/java/org/apache/polaris/service/admin/PolarisAuthzTestBase.java @@ -579,7 +579,7 @@ public Catalog createCallContextCatalog( * @param cleanupAction If non-null, additional action to run to "undo" a previous success action * in case the action has side effects. Called before revoking the sufficient privilege; * either the cleanup privileges must be latent, or the cleanup action could be run with - * PRINCIPAL_ROLE2 while runnint {@code action} with PRINCIPAL_ROLE1. + * PRINCIPAL_ROLE2 while running {@code action} with PRINCIPAL_ROLE1. * @param principalName the name expected to appear in forbidden errors * @param grantAction the grantPrivilege action to use for each test privilege that will apply the * privilege to whatever context is used in the {@code action} diff --git a/runtime/service/src/test/java/org/apache/polaris/service/catalog/generic/PolarisGenericTableCatalogHandlerAuthzTest.java b/runtime/service/src/test/java/org/apache/polaris/service/catalog/generic/PolarisGenericTableCatalogHandlerAuthzTest.java index b1296177b7..c3a5ac21c9 100644 --- a/runtime/service/src/test/java/org/apache/polaris/service/catalog/generic/PolarisGenericTableCatalogHandlerAuthzTest.java +++ b/runtime/service/src/test/java/org/apache/polaris/service/catalog/generic/PolarisGenericTableCatalogHandlerAuthzTest.java @@ -69,7 +69,7 @@ private GenericTableCatalogHandler newWrapper( * @param cleanupAction If non-null, additional action to run to "undo" a previous success action * in case the action has side effects. Called before revoking the sufficient privilege; * either the cleanup privileges must be latent, or the cleanup action could be run with - * PRINCIPAL_ROLE2 while runnint {@code action} with PRINCIPAL_ROLE1. + * PRINCIPAL_ROLE2 while running {@code action} with PRINCIPAL_ROLE1. */ private void doTestSufficientPrivileges( List sufficientPrivileges, Runnable action, Runnable cleanupAction) { diff --git a/runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandlerAuthzTest.java b/runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandlerAuthzTest.java index f3cd56162d..94030d539d 100644 --- a/runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandlerAuthzTest.java +++ b/runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandlerAuthzTest.java @@ -171,7 +171,7 @@ private void doTestInsufficientPrivileges( * @param cleanupAction If non-null, additional action to run to "undo" a previous success action * in case the action has side effects. Called before revoking the sufficient privilege; * either the cleanup privileges must be latent, or the cleanup action could be run with - * PRINCIPAL_ROLE2 while runnint {@code action} with PRINCIPAL_ROLE1. + * PRINCIPAL_ROLE2 while running {@code action} with PRINCIPAL_ROLE1. */ protected void doTestSufficientPrivileges( List sufficientPrivileges, Runnable action, Runnable cleanupAction) { @@ -946,7 +946,7 @@ public void testLoadTableWithWriteAccessDelegationSufficientPrivileges() { doTestSufficientPrivileges( List.of( // TODO: Once we give different creds for read/write privilege, move this - // TABLE_READ_DATA into a special-case test; with only TABLE_READ_DATA we'd expet + // TABLE_READ_DATA into a special-case test; with only TABLE_READ_DATA we'd expect // to receive a read-only credential. PolarisPrivilege.TABLE_READ_DATA, PolarisPrivilege.TABLE_WRITE_DATA, @@ -1007,7 +1007,7 @@ public void testLoadTableWithWriteAccessDelegationIfStaleSufficientPrivileges() doTestSufficientPrivileges( List.of( // TODO: Once we give different creds for read/write privilege, move this - // TABLE_READ_DATA into a special-case test; with only TABLE_READ_DATA we'd expet + // TABLE_READ_DATA into a special-case test; with only TABLE_READ_DATA we'd expect // to receive a read-only credential. PolarisPrivilege.TABLE_READ_DATA, PolarisPrivilege.TABLE_WRITE_DATA, diff --git a/runtime/service/src/test/java/org/apache/polaris/service/catalog/policy/PolicyCatalogHandlerAuthzTest.java b/runtime/service/src/test/java/org/apache/polaris/service/catalog/policy/PolicyCatalogHandlerAuthzTest.java index 990a9cff28..5a7e5149fd 100644 --- a/runtime/service/src/test/java/org/apache/polaris/service/catalog/policy/PolicyCatalogHandlerAuthzTest.java +++ b/runtime/service/src/test/java/org/apache/polaris/service/catalog/policy/PolicyCatalogHandlerAuthzTest.java @@ -74,7 +74,7 @@ private PolicyCatalogHandler newWrapper(Set activatedPrincipalRoles, Str * @param cleanupAction If non-null, additional action to run to "undo" a previous success action * in case the action has side effects. Called before revoking the sufficient privilege; * either the cleanup privileges must be latent, or the cleanup action could be run with - * PRINCIPAL_ROLE2 while runnint {@code action} with PRINCIPAL_ROLE1. + * PRINCIPAL_ROLE2 while running {@code action} with PRINCIPAL_ROLE1. */ private void doTestSufficientPrivileges( List sufficientPrivileges, Runnable action, Runnable cleanupAction) { diff --git a/runtime/service/src/test/java/org/apache/polaris/service/test/TestEnvironmentExtension.java b/runtime/service/src/test/java/org/apache/polaris/service/test/TestEnvironmentExtension.java index de2e346c9a..d5b2671be8 100644 --- a/runtime/service/src/test/java/org/apache/polaris/service/test/TestEnvironmentExtension.java +++ b/runtime/service/src/test/java/org/apache/polaris/service/test/TestEnvironmentExtension.java @@ -27,7 +27,7 @@ import org.junit.jupiter.api.extension.ParameterResolver; /** - * JUnit test extension that determines the TestEnvironment. Falls back to targetting the local + * JUnit test extension that determines the TestEnvironment. Falls back to targeting the local * Dropwizard instance. */ public class TestEnvironmentExtension implements ParameterResolver { diff --git a/site/content/blog/2025/09/19/apache-polaris-1.1.0-incubating.md b/site/content/blog/2025/09/19/apache-polaris-1.1.0-incubating.md index 1e6e3027dd..691eeffecf 100644 --- a/site/content/blog/2025/09/19/apache-polaris-1.1.0-incubating.md +++ b/site/content/blog/2025/09/19/apache-polaris-1.1.0-incubating.md @@ -24,7 +24,7 @@ date: 2025-09-19 The Apache Polaris team is pleased to announce Apache Polaris 1.1.0-incubating. This release includes: -* **New features & enchancements** +* **New features & enhancements** ** HMS support ** IMPLICIT authentication type ** Support for non-AWS S3 compatible storage with STS: MinIO, s3a scheme support diff --git a/site/content/in-dev/unreleased/generic-table.md b/site/content/in-dev/unreleased/generic-table.md index 63ef38a1da..3c48338d01 100644 --- a/site/content/in-dev/unreleased/generic-table.md +++ b/site/content/in-dev/unreleased/generic-table.md @@ -164,6 +164,6 @@ Current limitations of Generic Table support: 2) No commit coordination or update capability provided at the catalog service level. Therefore, the catalog itself is unaware of anything about the underlying table except some of the loosely defined metadata. -It is the responsibility of the engine (and plugins used by the engine) to determine exactly how loading or commiting data +It is the responsibility of the engine (and plugins used by the engine) to determine exactly how loading or committing data should look like based on the metadata. For example, with the delta support, th delta log serialization, deserialization and update all happens at client side. diff --git a/site/content/in-dev/unreleased/managing-security/_index.md b/site/content/in-dev/unreleased/managing-security/_index.md index 3a10c8900b..ec680572c1 100644 --- a/site/content/in-dev/unreleased/managing-security/_index.md +++ b/site/content/in-dev/unreleased/managing-security/_index.md @@ -25,4 +25,4 @@ weight: 550 ## [Access Control]({{< relref "access-control" >}}) -## [Authentification and Identity Providers]({{< relref "external-idp" >}}) \ No newline at end of file +## [Authentication and Identity Providers]({{< relref "external-idp" >}}) \ No newline at end of file diff --git a/site/content/in-dev/unreleased/managing-security/external-idp/idp-dev-notes.md b/site/content/in-dev/unreleased/managing-security/external-idp/idp-dev-notes.md index 16bc759b8d..27ab61cc11 100644 --- a/site/content/in-dev/unreleased/managing-security/external-idp/idp-dev-notes.md +++ b/site/content/in-dev/unreleased/managing-security/external-idp/idp-dev-notes.md @@ -17,7 +17,7 @@ # specific language governing permissions and limitations # under the License. # -title: Authentification Development Details +title: Authentication Development Details linkTitle: Development Details type: docs weight: 301 diff --git a/spec/polaris-management-service.yml b/spec/polaris-management-service.yml index 461c0ad3fc..d1775b7598 100644 --- a/spec/polaris-management-service.yml +++ b/spec/polaris-management-service.yml @@ -1053,7 +1053,7 @@ components: ImplicitAuthenticationParameters: type: object - description: Polaris does not explicity accept any authentication parameters for the connection. Authentication + description: Polaris does not explicitly accept any authentication parameters for the connection. Authentication parameters found in the environment and/or configuration files will be used for this connection. allOf: - $ref: '#/components/schemas/AuthenticationParameters' From e0393db2536a9e6d8df14279967d01eb295adc2c Mon Sep 17 00:00:00 2001 From: Yong Date: Sun, 2 Nov 2025 13:13:45 -0600 Subject: [PATCH 2/2] Fix findings with codespell --- .../org/apache/polaris/spark/utils/PolarisCatalogUtils.java | 4 ++-- .../java/org/apache/polaris/core/entity/PolarisEntity.java | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/utils/PolarisCatalogUtils.java b/plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/utils/PolarisCatalogUtils.java index d6d9edb576..98016b71fd 100644 --- a/plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/utils/PolarisCatalogUtils.java +++ b/plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/utils/PolarisCatalogUtils.java @@ -51,8 +51,8 @@ public static boolean useDelta(String provider) { } /** - * For tables whose location is managed by Spark Session Catalog, there will be no location or path - * in the properties. + * For tables whose location is managed by Spark Session Catalog, there will be no location or + * path in the properties. */ public static boolean isTableWithSparkManagedLocation(Map properties) { boolean hasLocationClause = properties.containsKey(TableCatalog.PROP_LOCATION); diff --git a/polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisEntity.java b/polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisEntity.java index 44f34fa93b..f9d406c873 100644 --- a/polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisEntity.java +++ b/polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisEntity.java @@ -36,9 +36,9 @@ * direct members should be added to this class; rather, they should reside in the PolarisBaseEntity * and this class should just contain the relevant builder methods, etc. The intention when using * this class is to use "immutable" semantics as much as possible, for example constructing new - * copies with the Builder pattern when "mutating" fields rather than directly changing fields in-place. - * Currently, code that intends to operate directly on a PolarisBaseEntity may not adhere to - * immutability semantics, and may modify the entity in-place. + * copies with the Builder pattern when "mutating" fields rather than directly changing fields + * in-place. Currently, code that intends to operate directly on a PolarisBaseEntity may not adhere + * to immutability semantics, and may modify the entity in-place. * *

TODO: Combine this fully into PolarisBaseEntity, refactor all callsites to use strict * immutability semantics, and remove all mutator methods from PolarisBaseEntity.