Skip to content

Releasy: prepare for Helm 4 (helm package repro) #3088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2025
Merged

Releasy: prepare for Helm 4 (helm package repro) #3088

merged 1 commit into from
Nov 26, 2025

Conversation

@snazy
Copy link
Member

@snazy snazy commented Nov 19, 2025

Part of #3086

@snazy snazy requested a review from pingtimeout November 19, 2025 10:37
@github-project-automation github-project-automation bot moved this to PRs In Progress in Basic Kanban Board Nov 19, 2025
snazy added a commit to snazy/polaris that referenced this pull request Nov 19, 2025
@snazy
Add same change as in apache#3088
248911c
pingtimeout
pingtimeout reviewed Nov 20, 2025
View reviewed changes
Copy link
Contributor

@pingtimeout pingtimeout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this is necessary. Could you help me clarify this?

In #3086 you added a link to helm/helm#31323. IIUC that link says that the next Helm version will use file modification time as archive creation time. Which means that for a given Git SHA, building the chart multiple times will yield the same result. There should be no need to tweak the file modification time.

What am I missing?

@snazy
Copy link
Member Author

snazy commented Nov 20, 2025

In #3086 you added a link to helm/helm#31323. IIUC that link says that the next Helm version will use file modification time as archive creation time. Which means that for a given Git SHA, building the chart multiple times will yield the same result. There should be no need to tweak the file modification time.

The file modification timestamps after a git clone are the timestamps at which the file was created.

pingtimeout
pingtimeout approved these changes Nov 20, 2025
View reviewed changes
Copy link
Contributor

@pingtimeout pingtimeout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL the file modification timestamps reflect when git clone was executed, not when the files were originally committed to the repository.

+1

@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Nov 20, 2025
snazy added a commit to snazy/polaris that referenced this pull request Nov 21, 2025
@snazy
Add same change as in apache#3088
deb6185
snazy added a commit to snazy/polaris that referenced this pull request Nov 24, 2025
@snazy
Add same change as in apache#3088
96c61fe
snazy added a commit to snazy/polaris that referenced this pull request Nov 25, 2025
@snazy
Add same change as in apache#3088
7266d09
@snazy snazy merged commit 26c56ee into apache:main Nov 26, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Nov 26, 2025
@snazy snazy deleted the prep-helm-4-repro branch November 26, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pingtimeout pingtimeout pingtimeout approved these changes

@MonkeyCanCode MonkeyCanCode MonkeyCanCode approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@snazy @pingtimeout @MonkeyCanCode