adapter-indexeddb: replace var with let/const (#8926)

Author: alxndrsn

packages/node_modules/pouchdb-adapter-indexeddb/src/allDocs.js

@@ -7,8 +7,8 @@ import { DOC_STORE, processAttachment } from './util';
 
 function allDocsKeys(keys, docStore, allDocsInner) {
   // It's not guaranteed to be returned in right order
-  var valuesBatch = new Array(keys.length);
-  var count = 0;
+  const valuesBatch = new Array(keys.length);
+  let count = 0;
   keys.forEach(function (key, index) {
     docStore.get(key).onsuccess = function (event) {
       if (event.target.result) {
@@ -43,7 +43,7 @@ function createKeyRange(start, end, inclusiveStart, inclusiveEnd, key, descendin
 function handleKeyRangeError(opts, metadata, err, callback) {
   if (err.name === "DataError" && err.code === 0) {
     // data error, start is less than end
-    var returnVal = {
+    const returnVal = {
       total_rows: metadata.doc_count,
       offset: opts.skip,
       rows: []
@@ -64,7 +64,7 @@ export default function (txn, metadata, opts, callback) {
 
   // TODO: Weird hack, I don't like it
   if (opts.limit === 0) {
-    var returnVal = {
+    const returnVal = {
       total_rows: metadata.doc_count,
       offset: opts.skip,
       rows: []
@@ -77,19 +77,19 @@ export default function (txn, metadata, opts, callback) {
     return callback(null, returnVal);
   }
 
-  var results = [];
-  var processing = [];
+  const results = [];
+  const processing = [];
 
-  var key = 'key' in opts ? opts.key : false;
-  var keys = 'keys' in opts ? opts.keys : false;
-  var skip = opts.skip || 0;
-  var limit = typeof opts.limit === 'number' ? opts.limit : undefined;
-  var inclusiveEnd = opts.inclusive_end !== false;
-  var descending = 'descending' in opts && opts.descending ? 'prev' : null;
-  var start = 'startkey' in opts ? opts.startkey : (descending ?  '\uffff' : '');
-  var end   = 'endkey'   in opts ? opts.endkey   : (descending ? '' :  '\uffff');
+  const key = 'key' in opts ? opts.key : false;
+  const keys = 'keys' in opts ? opts.keys : false;
+  let skip = opts.skip || 0;
+  let limit = typeof opts.limit === 'number' ? opts.limit : undefined;
+  const inclusiveEnd = opts.inclusive_end !== false;
+  const descending = 'descending' in opts && opts.descending ? 'prev' : null;
+  const start = 'startkey' in opts ? opts.startkey : (descending ?  '\uffff' : '');
+  const end   = 'endkey'   in opts ? opts.endkey   : (descending ? '' :  '\uffff');
 
-  var docStore = txn.txn.objectStore(DOC_STORE);
+  const docStore = txn.txn.objectStore(DOC_STORE);
 
   if (keys) {
     txn.txn.oncomplete = onTxnComplete;
@@ -121,19 +121,19 @@ export default function (txn, metadata, opts, callback) {
   txn.txn.oncomplete = onTxnComplete;
 
   function include_doc(row, doc) {
-    var docData = doc.revs[doc.rev].data;
+    const docData = doc.revs[doc.rev].data;
 
     row.doc = docData;
     row.doc._id = doc.id;
     row.doc._rev = doc.rev;
     if (opts.conflicts) {
-      var conflicts = collectConflicts(doc);
+      const conflicts = collectConflicts(doc);
       if (conflicts.length) {
         row.doc._conflicts = conflicts;
       }
     }
     if (opts.attachments && docData._attachments) {
-      for (var name in docData._attachments) {
+      for (const name in docData._attachments) {
         processing.push(processAttachment(name, doc, row.doc, opts.binary,
             metadata.idb_attachment_format));
       }

packages/node_modules/pouchdb-adapter-indexeddb/src/bulkDocs.js

@@ -25,16 +25,16 @@ import { rewrite } from './rewrite';
 
 export default function (api, req, opts, metadata, dbOpts, idbChanges, callback) {
 
-  var txn;
+  let txn;
 
   // TODO: I would prefer to get rid of these globals
-  var error;
-  var results = [];
-  var docs = [];
-  var lastWriteIndex;
+  let error;
+  const results = [];
+  const docs = [];
+  let lastWriteIndex;
 
-  var revsLimit = dbOpts.revs_limit || 1000;
-  var rewriteEnabled = dbOpts.name.indexOf("-mrview-") === -1;
+  const revsLimit = dbOpts.revs_limit || 1000;
+  const rewriteEnabled = dbOpts.name.indexOf("-mrview-") === -1;
   const autoCompaction = dbOpts.auto_compaction;
 
   // We only need to track 1 revision for local documents
@@ -49,8 +49,8 @@ export default function (api, req, opts, metadata, dbOpts, idbChanges, callback)
   // Reads the original doc from the store if available
   // As in allDocs with keys option using multiple get calls is the fastest way
   function fetchExistingDocs(txn, docs) {
-    var fetched = 0;
-    var oldDocs = {};
+    let fetched = 0;
+    const oldDocs = {};
 
     function readDone(e) {
       if (e.target.result) {
@@ -78,7 +78,7 @@ export default function (api, req, opts, metadata, dbOpts, idbChanges, callback)
   function processDocs(txn, docs, oldDocs) {
 
     docs.forEach(function (doc, i) {
-      var newDoc;
+      let newDoc;
 
       // The first document write cannot be a deletion
       if ('was_delete' in opts && !(Object.prototype.hasOwnProperty.call(oldDocs, doc.id))) {
@@ -102,7 +102,7 @@ export default function (api, req, opts, metadata, dbOpts, idbChanges, callback)
       // New document
       } else {
         // Ensure new documents are also stemmed
-        var merged = merge([], doc.rev_tree[0], docsRevsLimit(doc));
+        const merged = merge([], doc.rev_tree[0], docsRevsLimit(doc));
         doc.rev_tree = merged.tree;
         doc.stemmedRevs = merged.stemmedRevs;
         newDoc = doc;
@@ -124,7 +124,7 @@ export default function (api, req, opts, metadata, dbOpts, idbChanges, callback)
   // we use to store
   function convertDocFormat(doc) {
 
-    var newDoc = {
+    const newDoc = {
       id: doc.metadata.id,
       rev: doc.metadata.rev,
       rev_tree: doc.metadata.rev_tree,
@@ -146,28 +146,28 @@ export default function (api, req, opts, metadata, dbOpts, idbChanges, callback)
       return false;
     }
 
-    var isRoot = /^1-/.test(doc.rev);
+    const isRoot = /^1-/.test(doc.rev);
 
     // Reattach first writes after a deletion to last deleted tree
     if (oldDoc.deleted && !doc.deleted && opts.new_edits && isRoot) {
-      var tmp = doc.revs[doc.rev].data;
+      const tmp = doc.revs[doc.rev].data;
       tmp._rev = oldDoc.rev;
       tmp._id = oldDoc.id;
       doc = convertDocFormat(parseDoc(tmp, opts.new_edits, dbOpts));
     }
 
-    var merged = merge(oldDoc.rev_tree, doc.rev_tree[0], docsRevsLimit(doc));
+    const merged = merge(oldDoc.rev_tree, doc.rev_tree[0], docsRevsLimit(doc));
     doc.stemmedRevs = merged.stemmedRevs;
     doc.rev_tree = merged.tree;
 
     // Merge the old and new rev data
-    var revs = oldDoc.revs;
+    const revs = oldDoc.revs;
     revs[doc.rev] = doc.revs[doc.rev];
     doc.revs = revs;
 
     doc.attachments = oldDoc.attachments;
 
-    var inConflict = opts.new_edits && (((oldDoc.deleted && doc.deleted) ||
+    const inConflict = opts.new_edits && (((oldDoc.deleted && doc.deleted) ||
        (!oldDoc.deleted && merged.conflicts !== 'new_leaf') ||
        (oldDoc.deleted && !doc.deleted && merged.conflicts === 'new_branch') ||
        (oldDoc.rev === doc.rev)));
@@ -185,19 +185,19 @@ export default function (api, req, opts, metadata, dbOpts, idbChanges, callback)
 
     // We copy the data from the winning revision into the root
     // of the document so that it can be indexed
-    var winningRev = calculateWinningRev(doc);
+    const winningRev = calculateWinningRev(doc);
     // rev of new doc for attachments and to return it
-    var writtenRev = doc.rev;
+    const writtenRev = doc.rev;
     const isLocal = isLocalId(doc.id);
 
-    var theDoc = doc.revs[winningRev].data;
+    const theDoc = doc.revs[winningRev].data;
 
     const isNewDoc = doc.isNewDoc;
 
     if (rewriteEnabled) {
       // doc.data is what we index, so we need to clone and rewrite it, and clean
       // it up for indexability
-      var result = rewrite(theDoc);
+      const result = rewrite(theDoc);
       if (result) {
         doc.data = result;
         delete doc.data._attachments;
@@ -216,7 +216,7 @@ export default function (api, req, opts, metadata, dbOpts, idbChanges, callback)
     if (!isLocal) {
       doc.seq = ++metadata.seq;
 
-      var delta = 0;
+      let delta = 0;
       // If its a new document, we wont decrement if deleted
       if (doc.isNewDoc) {
         delta = doc.deleted ? 0 : 1;
@@ -250,8 +250,8 @@ export default function (api, req, opts, metadata, dbOpts, idbChanges, callback)
     }
 
     if (theDoc._attachments) {
-      for (var k in theDoc._attachments) {
-        var attachment = theDoc._attachments[k];
+      for (const k in theDoc._attachments) {
+        const attachment = theDoc._attachments[k];
         if (attachment.stub) {
           if (!(attachment.digest in doc.attachments)) {
             error = createError(MISSING_STUB);
@@ -317,7 +317,7 @@ export default function (api, req, opts, metadata, dbOpts, idbChanges, callback)
       return Promise.resolve(attachment);
     }
 
-    var binData;
+    let binData;
     if (typeof attachment.data === 'string') {
       try {
         binData = atob(attachment.data);
@@ -354,18 +354,18 @@ export default function (api, req, opts, metadata, dbOpts, idbChanges, callback)
   }
 
   function preProcessAttachments() {
-    var promises = docs.map(function (doc) {
-      var data = doc.revs[doc.rev].data;
+    const promises = docs.map(function (doc) {
+      const data = doc.revs[doc.rev].data;
       if (!data._attachments) {
         return Promise.resolve(data);
       }
-      var attachments = Object.keys(data._attachments).map(function (k) {
+      const attachments = Object.keys(data._attachments).map(function (k) {
         data._attachments[k].name = k;
         return preProcessAttachment(data._attachments[k]);
       });
 
       return Promise.all(attachments).then(function (newAttachments) {
-        var processed = {};
+        const processed = {};
         newAttachments.forEach(function (attachment) {
           processed[attachment.name] = attachment;
           delete attachment.name;
@@ -377,8 +377,8 @@ export default function (api, req, opts, metadata, dbOpts, idbChanges, callback)
     return Promise.all(promises);
   }
 
-  for (var i = 0, len = req.docs.length; i < len; i++) {
-    var result;
+  for (let i = 0, len = req.docs.length; i < len; i++) {
+    let result;
     // TODO: We should get rid of throwing for invalid docs, also not sure
     // why this is needed in idb-next and not idb
     try {

packages/node_modules/pouchdb-adapter-indexeddb/src/changes.js

@@ -10,7 +10,7 @@ export default function (txn, idbChanges, api, dbOpts, opts) {
   }
 
   if (opts.continuous) {
-    var id = dbOpts.name + ':' + uuid();
+    const id = dbOpts.name + ':' + uuid();
     idbChanges.addListener(dbOpts.name, id, api, opts);
     idbChanges.notify(dbOpts.name);
     return {
@@ -20,25 +20,25 @@ export default function (txn, idbChanges, api, dbOpts, opts) {
     };
   }
 
-  var limit = 'limit' in opts ? opts.limit : -1;
+  let limit = 'limit' in opts ? opts.limit : -1;
   if (limit === 0) {
     limit = 1;
   }
 
-  var store = txn.txn.objectStore(DOC_STORE).index('seq');
+  const store = txn.txn.objectStore(DOC_STORE).index('seq');
 
-  var filter = filterChange(opts);
-  var received = 0;
+  const filter = filterChange(opts);
+  let received = 0;
 
-  var lastSeq = opts.since || 0;
-  var results = [];
+  let lastSeq = opts.since || 0;
+  const results = [];
 
-  var processing = [];
+  const processing = [];
 
   function onReqSuccess(e) {
     if (!e.target.result) { return; }
-    var cursor = e.target.result;
-    var doc = cursor.value;
+    const cursor = e.target.result;
+    const doc = cursor.value;
     // Overwrite doc.data, which may have been rewritten (see rewrite.js) with
     // the clean version for that rev
     doc.data = doc.revs[doc.rev].data;
@@ -53,10 +53,10 @@ export default function (txn, idbChanges, api, dbOpts, opts) {
     }
 
     // WARNING: expecting possible old format
-    var change = opts.processChange(doc.data, doc, opts);
+    const change = opts.processChange(doc.data, doc, opts);
     change.seq = doc.seq;
     lastSeq = doc.seq;
-    var filtered = filter(change);
+    const filtered = filter(change);
 
     // If its an error
     if (typeof filtered === 'object') {
@@ -70,9 +70,9 @@ export default function (txn, idbChanges, api, dbOpts, opts) {
       }
 
       if (opts.include_docs && opts.attachments && doc.data._attachments) {
-        var promises = [];
-        for (var name in doc.data._attachments) {
-          var p = processAttachment(name, doc, change.doc, opts.binary, api.blobSupport);
+        const promises = [];
+        for (const name in doc.data._attachments) {
+          const p = processAttachment(name, doc, change.doc, opts.binary, api.blobSupport);
           // We add the processing promise to 2 arrays, one tracks all
           // the promises needed before we fire onChange, the other
           // ensure we process all attachments before onComplete
@@ -101,7 +101,7 @@ export default function (txn, idbChanges, api, dbOpts, opts) {
     });
   }
 
-  var req;
+  let req;
   if (opts.descending) {
     req = store.openCursor(null, 'prev');
   } else {

packages/node_modules/pouchdb-adapter-indexeddb/src/destroy.js

@@ -5,7 +5,7 @@ export default function (dbOpts, openDatabases, idbChanges, callback) {
   idbChanges.removeAllListeners(dbOpts.name);
 
   function doDestroy() {
-    var req = indexedDB.deleteDatabase(dbOpts.name);
+    const req = indexedDB.deleteDatabase(dbOpts.name);
     req.onsuccess = function () {
       delete openDatabases[dbOpts.name];
       callback(null, {ok: true});

packages/node_modules/pouchdb-adapter-indexeddb/src/doCompaction.js

@@ -9,26 +9,26 @@ export default function (txn, id, revs, callback) {
     return callback(txn.error);
   }
 
-  var docStore = txn.txn.objectStore(DOC_STORE);
+  const docStore = txn.txn.objectStore(DOC_STORE);
 
   docStore.get(id).onsuccess = function (e) {
-    var doc = e.target.result;
+    const doc = e.target.result;
 
     traverseRevTree(doc.rev_tree, function (isLeaf, pos, revHash, ctx, opts) {
-      var rev = pos + '-' + revHash;
+      const rev = pos + '-' + revHash;
       if (revs.indexOf(rev) !== -1) {
         opts.status = 'missing';
       }
     });
 
-    var attachments = [];
+    const attachments = [];
 
     revs.forEach(function (rev) {
       if (rev in doc.revs) {
         // Make a list of attachments that are used by the revisions being
         // deleted
         if (doc.revs[rev].data._attachments) {
-          for (var k in doc.revs[rev].data._attachments) {
+          for (const k in doc.revs[rev].data._attachments) {
             attachments.push(doc.revs[rev].data._attachments[k].digest);
           }
         }