db.post(), db.bulkDocs(): throw INVALID_REV consistently (#8934)

Follow-up to #8931

Author: alxndrsn

packages/node_modules/pouchdb-core/src/adapter.js

@@ -789,9 +789,13 @@ class AbstractPouchDB extends EventEmitter {
       }
 
       for (var i = 0; i < req.docs.length; ++i) {
-        if (isNotSingleDoc(req.docs[i])) {
+        const doc = req.docs[i];
+        if (isNotSingleDoc(doc)) {
           return callback(createError(NOT_AN_OBJECT));
         }
+        if ('_rev' in doc && !isValidRev(doc._rev)) {
+          return callback(createError(INVALID_REV));
+        }
       }
 
       var attachmentError;

tests/integration/test.basics.js

@@ -293,6 +293,25 @@ adapters.forEach(function (adapter) {
       ({ rev }) => ({ toString:() => rev, indexOf:() => 12, substring:'hi' }),
       ({ rev }) => ({ toString:() => rev, indexOf:() => 12, substring:() => 'hi' }),
     ].forEach((generateRev, idx) => {
+      it(`post doc with illegal rev value #${idx}`, async () => {
+        const db = new PouchDB(dbs.name);
+
+        let threw;
+        try {
+          await db.post({
+            _rev: generateRev({ rev:'1-valid' }),
+            another: 'test'
+          });
+        } catch (err) {
+          threw = true;
+          err.message.should.equal('Invalid rev format'); // TODO should be err.reason?
+        }
+
+        if (!threw) {
+          throw new Error('db.put() should have thrown.');
+        }
+      });
+
       it(`Modify a doc with illegal rev value #${idx}`, async () => {
         const db = new PouchDB(dbs.name);
 
@@ -314,6 +333,52 @@ adapters.forEach(function (adapter) {
           throw new Error('db.put() should have thrown.');
         }
       });
+
+      it(`bulkDocs with illegal rev value #${idx} (existing doc)`, async () => {
+        const db = new PouchDB(dbs.name);
+
+        const info = await db.post({ test: 'somestuff' });
+
+        let threw;
+        try {
+          await db.bulkDocs({
+            docs: [ {
+              _id: info.id,
+              _rev: generateRev(info),
+              another: 'test'
+            } ],
+          });
+        } catch (err) {
+          threw = true;
+          err.message.should.equal('Invalid rev format'); // TODO should be err.reason?
+        }
+
+        if (!threw) {
+          throw new Error('db.put() should have thrown.');
+        }
+      });
+
+      it(`bulkDocs with illegal rev value #${idx} (new doc)`, async () => {
+        const db = new PouchDB(dbs.name);
+
+        let threw;
+        try {
+          await db.bulkDocs({
+            docs: [ {
+              _id: '1',
+              _rev: generateRev({ rev:'1_valid' }),
+              another: 'test'
+            } ],
+          });
+        } catch (err) {
+          threw = true;
+          err.message.should.equal('Invalid rev format'); // TODO should be err.reason?
+        }
+
+        if (!threw) {
+          throw new Error('db.put() should have thrown.');
+        }
+      });
     });
 
     it('Remove doc', function (done) {