perf-tests: fix JSON reporter (#8876)

Since runner.completed was removed in dc97aed,
env var JSON_REPORTER has not worked.

This also changes the exit status code for perf tests: previously the process
would always exit with status 0, even if there was a test failure.  Test
failure(s) will now result in an exit status of 0.

Co-authored-by: alxndrsn <alxndrsn>

Author: alxndrsn

bin/test-browser.js

@@ -72,6 +72,7 @@ class ArrayMap extends Map {
 
 class RemoteRunner {
   constructor(browser) {
+    this.failed = false;
     this.browser = browser;
     this.handlers = new ArrayMap();
     this.onceHandlers = new ArrayMap();
@@ -120,20 +121,21 @@ class RemoteRunner {
     }
   }
 
-  async handleEnd(failed) {
+  async handleEnd() {
     closeRequested = true;
     await this.browser.close();
-    process.exit(!process.env.PERF && failed ? 1 : 0);
+    process.exit(this.failed ? 1 : 0);
   }
 
   handleFailed() {
+    this.failed = true;
     if (bail) {
       try {
         this.triggerHandlers('end');
       } catch (e) {
         console.log('An error occurred while bailing:', e);
       } finally {
-        this.handleEnd(true);
+        this.handleEnd();
       }
     }
   }
@@ -147,7 +149,9 @@ function BenchmarkConsoleReporter(runner) {
 
 function BenchmarkJsonReporter(runner) {
   runner.on('end', results => {
-    if (runner.completed) {
+    if (runner.failed) {
+      console.log('Runner failed; JSON will not be writted.');
+    } else {
       const { mkdirSync, writeFileSync } = require('fs');
 
       const resultsDir = 'perf-test-results';
@@ -156,8 +160,6 @@ function BenchmarkJsonReporter(runner) {
       const jsonPath = `${resultsDir}/${new Date().toISOString()}.json`;
       writeFileSync(jsonPath, JSON.stringify(results, null, 2));
       console.log('Wrote JSON results to:', jsonPath);
-    } else {
-      console.log('Runner failed; JSON will not be writted.');
     }
   });
 }