(#8672) - eslint: introduce rule: no-trailing-spaces

Co-authored-by: alxndrsn <alxndrsn>

Author: alxndrsn

.eslintrc.json

@@ -36,6 +36,7 @@
     "eol-last": "error",
     "no-empty": "off",
     "no-console": "off",
+    "no-trailing-spaces": "error",
     "semi": ["error", "always"],
     "curly": ["error", "all"],
     "space-unary-ops": ["error", {"words": true}],

bin/test-browser.js

@@ -125,7 +125,7 @@ class RemoteRunner {
 
   on(name, handler) {
     var handlers = this.handlers;
-  
+
     if (!handlers[name]) {
       handlers[name] = [];
     }
@@ -134,21 +134,21 @@ class RemoteRunner {
 
   handleEvents(events) {
     var handlers = this.handlers;
-  
+
     events.forEach((event) => {
       this.completed = this.completed || event.name === 'end';
       this.failed = this.failed || event.name === 'fail';
-  
+
       var additionalProps = ['pass', 'fail', 'pending'].indexOf(event.name) === -1 ? {} : {
         slow: event.obj.slow ? function () { return event.obj.slow; } : function () { return 60; },
         fullTitle: event.obj.fullTitle ? function () { return event.obj.fullTitle; } : undefined
       };
       var obj = Object.assign({}, event.obj, additionalProps);
-  
+
       handlers[event.name].forEach(function (handler) {
         handler(obj, event.err);
       });
-  
+
       if (event.logs && event.logs.length > 0) {
         event.logs.forEach(function (line) {
           if (line.type === 'log') {
@@ -163,14 +163,14 @@ class RemoteRunner {
       }
     });
   }
-  
+
   bail() {
     var handlers = this.handlers;
-  
+
     handlers['end'].forEach(function (handler) {
       handler();
     });
-  
+
     this.completed = true;
   }
 }

packages/node_modules/pouchdb-abstract-mapreduce/src/index.js

@@ -708,7 +708,7 @@ function createAbstractMapReduce(localDocName, mapper, reducer, ddocValidator) {
       view.seq = currentSeq;
       view.sourceDB.activeTasks.remove(taskId);
     } catch (error) {
-      view.sourceDB.activeTasks.remove(taskId, error);      
+      view.sourceDB.activeTasks.remove(taskId, error);
     }
   }
 

packages/node_modules/pouchdb-adapter-idb/src/allDocs.js

@@ -18,7 +18,7 @@ import runBatchedCursor from './runBatchedCursor';
 import getAll from './getAll';
 
 function allDocsKeys(keys, docStore, onBatch) {
-  // It's not guaranted to be returned in right order  
+  // It's not guaranted to be returned in right order
   var valuesBatch = new Array(keys.length);
   var count = 0;
   keys.forEach(function (key, index) {
@@ -69,17 +69,17 @@ function idbAllDocs(opts, idb, callback) {
   var start = 'startkey' in opts ? opts.startkey : false;
   var end = 'endkey' in opts ? opts.endkey : false;
   var key = 'key' in opts ? opts.key : false;
-  var keys = 'keys' in opts ? opts.keys : false; 
+  var keys = 'keys' in opts ? opts.keys : false;
   var skip = opts.skip || 0;
   var limit = typeof opts.limit === 'number' ? opts.limit : -1;
   var inclusiveEnd = opts.inclusive_end !== false;
 
-  var keyRange ; 
+  var keyRange ;
   var keyRangeError;
   if (!keys) {
     keyRange = createKeyRange(start, end, inclusiveEnd, key, opts.descending);
     keyRangeError = keyRange && keyRange.error;
-    if (keyRangeError && 
+    if (keyRangeError &&
       !(keyRangeError.name === "DataError" && keyRangeError.code === 0)) {
       // DataError with error code 0 indicates start is less than end, so
       // can just do an empty query. Else need to throw
@@ -114,7 +114,7 @@ function idbAllDocs(opts, idb, callback) {
 
   /* istanbul ignore if */
   if (opts.update_seq) {
-    getMaxUpdateSeq(seqStore, function (e) { 
+    getMaxUpdateSeq(seqStore, function (e) {
       if (e.target.result && e.target.result.length > 0) {
         updateSeq = e.target.result[0];
       }
@@ -127,7 +127,7 @@ function idbAllDocs(opts, idb, callback) {
       var maxKey = undefined;
       if (cursor && cursor.key) {
         maxKey = cursor.key;
-      } 
+      }
       return onSuccess({
         target: {
           result: [maxKey]
@@ -218,7 +218,7 @@ function idbAllDocs(opts, idb, callback) {
       offset: opts.skip,
       rows: results
     };
-    
+
     /* istanbul ignore if */
     if (opts.update_seq && updateSeq !== undefined) {
       returnVal.update_seq = updateSeq;

packages/node_modules/pouchdb-adapter-indexeddb/src/index.js

@@ -31,7 +31,7 @@ function IdbPouch(dbOpts, callback) {
   if (dbOpts.view_adapter) {
     console.log('Please note that the indexeddb adapter manages _find indexes itself, therefore it is not using your specified view_adapter');
   }
-  
+
   var api = this;
   var metadata = {};
 

packages/node_modules/pouchdb-checkpointer/src/index.js

@@ -116,7 +116,7 @@ class CheckpointerInternal {
 
   getCheckpoint() {
     var self = this;
-  
+
     if (self.opts && self.opts.writeSourceCheckpoint && !self.opts.writeTargetCheckpoint) {
       return self.src.get(self.id).then(function (sourceDoc) {
         return sourceDoc.last_seq || LOWEST_SEQ;
@@ -128,27 +128,27 @@ class CheckpointerInternal {
         return LOWEST_SEQ;
       });
     }
-  
+
     return self.target.get(self.id).then(function (targetDoc) {
       if (self.opts && self.opts.writeTargetCheckpoint && !self.opts.writeSourceCheckpoint) {
         return targetDoc.last_seq || LOWEST_SEQ;
       }
-  
+
       return self.src.get(self.id).then(function (sourceDoc) {
         // Since we can't migrate an old version doc to a new one
         // (no session id), we just go with the lowest seq in this case
         /* istanbul ignore if */
         if (targetDoc.version !== sourceDoc.version) {
           return LOWEST_SEQ;
         }
-  
+
         var version;
         if (targetDoc.version) {
           version = targetDoc.version.toString();
         } else {
           version = "undefined";
         }
-  
+
         if (version in comparisons) {
           return comparisons[version](targetDoc, sourceDoc);
         }

packages/node_modules/pouchdb-core/src/changes.js

@@ -73,15 +73,15 @@ class Changes extends EE {
       this.cancel();
     };
     db.once('destroyed', onDestroy);
-  
+
     opts.onChange = (change, pending, lastSeq) => {
       /* istanbul ignore if */
       if (this.isCancelled) {
         return;
       }
       tryCatchInChangeListener(this, change, pending, lastSeq);
     };
-  
+
     var promise = new Promise(function (fulfill, reject) {
       opts.complete = function (err, res) {
         if (err) {
@@ -100,9 +100,9 @@ class Changes extends EE {
     this.then(function (result) {
       complete(null, result);
     }, complete);
-  
-  
-  
+
+
+
     if (!db.taskqueue.isReady) {
       db.taskqueue.addTask((failed) => {
         if (failed) {
@@ -127,7 +127,7 @@ class Changes extends EE {
 
   validateChanges(opts) {
     var callback = opts.complete;
-  
+
     /* istanbul ignore else */
     if (PouchDB._changesFilterPlugin) {
       PouchDB._changesFilterPlugin.validate(opts, (err) => {
@@ -143,13 +143,13 @@ class Changes extends EE {
 
   doChanges(opts) {
     var callback = opts.complete;
-  
+
     opts = clone(opts);
     if ('live' in opts && !('continuous' in opts)) {
       opts.continuous = opts.live;
     }
     opts.processChange = processChange;
-  
+
     if (opts.since === 'latest') {
       opts.since = 'now';
     }
@@ -168,7 +168,7 @@ class Changes extends EE {
       }, callback);
       return;
     }
-  
+
     /* istanbul ignore else */
     if (PouchDB._changesFilterPlugin) {
       PouchDB._changesFilterPlugin.normalize(opts);
@@ -186,11 +186,11 @@ class Changes extends EE {
         }
       });
     }
-  
+
     if (!('descending' in opts)) {
       opts.descending = false;
     }
-  
+
     // 0 and 1 should return 1 document
     opts.limit = opts.limit === 0 ? 1 : opts.limit;
     opts.complete = callback;

packages/node_modules/pouchdb-find/src/adapters/local/find/query-planner.js

@@ -432,15 +432,15 @@ function getMultiFieldQueryOpts(selector, index) {
 
 function shouldShortCircuit(selector) {
   // We have a field to select from, but not a valid value
-  // this should result in a short circuited query 
+  // this should result in a short circuited query
   // just like the http adapter (couchdb) and mongodb
   // see tests for issue #7810
-  
+
   // @todo Use 'Object.values' when Node.js v6 support is dropped.
   const values = Object.keys(selector).map(function (key) {
     return selector[key];
   });
-  return values.some(function (val) { 
+  return values.some(function (val) {
     return typeof val === 'object' && Object.keys(val).length === 0;
 });
 }

packages/node_modules/pouchdb-replication/src/replication.js

@@ -33,7 +33,7 @@ class Replication extends EE {
       return;
     }
     this._readyCalled = true;
-  
+
     const onDestroy = () => {
       this.cancel();
     };

packages/node_modules/pouchdb-utils/src/changesHandler.js

@@ -6,9 +6,9 @@ import nextTick from './nextTick';
 export default class Changes extends EventEmitter {
   constructor() {
     super();
-    
+
     this._listeners = {};
-    
+
     if (hasLocalStorage()) {
       addEventListener("storage", (e) => {
         this.emit(e.key);
@@ -35,11 +35,11 @@ export default class Changes extends EventEmitter {
         'style', 'include_docs', 'attachments', 'conflicts', 'filter',
         'doc_ids', 'view', 'since', 'query_params', 'binary', 'return_docs'
       ]);
-  
+
       function onError() {
         inprogress = false;
       }
-  
+
       db.changes(changesOpts).on('change', function (c) {
         if (c.seq > opts.since && !opts.cancelled) {
           opts.since = c.seq;
@@ -55,23 +55,23 @@ export default class Changes extends EventEmitter {
     this._listeners[id] = eventFunction;
     this.on(dbName, eventFunction);
   }
-  
+
   removeListener(dbName, id) {
     if (!(id in this._listeners)) {
       return;
     }
     super.removeListener(dbName, this._listeners[id]);
     delete this._listeners[id];
   }
-  
+
   notifyLocalWindows(dbName) {
     //do a useless change on a storage thing
     //in order to get other windows's listeners to activate
     if (hasLocalStorage()) {
       localStorage[dbName] = (localStorage[dbName] === "a") ? "b" : "a";
     }
   }
-  
+
   notify(dbName) {
     this.emit(dbName);
     this.notifyLocalWindows(dbName);