isValidRev(): reject revs with more than one dash (#8933)

alxndrsn · web-flow · commit 7505bedd5464 · 2024-04-15T23:08:29.000+02:00
Follow-up to #8931
diff --git a/packages/node_modules/pouchdb-core/src/adapter.js b/packages/node_modules/pouchdb-core/src/adapter.js
@@ -195,7 +195,7 @@ function isNotSingleDoc(doc) {
 }
 
 function isValidRev(rev) {
-  return typeof rev === 'string' && /^\d+-/.test(rev);
+  return typeof rev === 'string' && /^\d+-[^-]*$/.test(rev);
 }
 
 class AbstractPouchDB extends EventEmitter {
diff --git a/tests/integration/test.basics.js b/tests/integration/test.basics.js
@@ -271,6 +271,7 @@ adapters.forEach(function (adapter) {
     [
       () => '-format',
       () => 'bad-format',
+      () => '1-ok-bad',
       () => ({}),
       () => ({ toString:'2-abc' }),
       () => ({ toString:'2-abc', indexOf:777 }),

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ function isNotSingleDoc(doc) {`
`195`	`195`	`}`
`196`	`196`
`197`	`197`	`function isValidRev(rev) {`
`198`		`- return typeof rev === 'string' && /^\d+-/.test(rev);`
	`198`	`+ return typeof rev === 'string' && /^\d+-[^-]*$/.test(rev);`
`199`	`199`	`}`
`200`	`200`
`201`	`201`	`class AbstractPouchDB extends EventEmitter {`
Original file line number	Diff line number	Diff line change
`@@ -271,6 +271,7 @@ adapters.forEach(function (adapter) {`
`271`	`271`	`[`
`272`	`272`	`() => '-format',`
`273`	`273`	`() => 'bad-format',`
	`274`	`+ () => '1-ok-bad',`
`274`	`275`	`() => ({}),`
`275`	`276`	`() => ({ toString:'2-abc' }),`
`276`	`277`	`() => ({ toString:'2-abc', indexOf:777 }),`