indexeddb.getAttachment: don't open unnecessary transaction (#8786)

Author: alxndrsn

packages/node_modules/pouchdb-adapter-indexeddb/src/getAttachment.js

@@ -2,11 +2,7 @@
 
 import { btoa, readAsBinaryString } from 'pouchdb-binary-utils';
 
-export default function getAttachment(txn, docId, attachId, attachment, opts, cb) {
-  if (txn.error) {
-    return cb(txn.error);
-  }
-
+export default function getAttachment(docId, attachId, attachment, opts, cb) {
   const doc = opts.metadata;
   const data = doc.attachments[attachment.digest].data;
 

packages/node_modules/pouchdb-adapter-indexeddb/src/index.js

@@ -118,7 +118,7 @@ function IndexeddbPouch(dbOpts, callback) {
     allDocs(txn, metadata, opts, cb);
   });
 
-  api._getAttachment = $t(getAttachment);
+  api._getAttachment = getAttachment;
 
   api._changes = $t(function (txn, opts) {
     changes(txn, idbChanges, api, dbOpts, opts);