chore(test): update mocha from v3.5 to v10 (#8838)

Co-authored-by: Gareth Bowen <gareth@medic.org>

Author: alxndrsn

bin/test-browser.js

@@ -6,6 +6,7 @@ const playwright = require('playwright');
 const { identity, pickBy } = require('lodash');
 
 var MochaSpecReporter = require('mocha').reporters.Spec;
+const createMochaStatsCollector = require('mocha/lib/stats-collector');
 
 var devserver = require('./dev-server.js');
 
@@ -59,20 +60,30 @@ const qs = {
 testUrl += '?';
 testUrl += new URLSearchParams(pickBy(qs, identity));
 
+class ArrayMap extends Map {
+  get(key) {
+    if (!this.has(key)) {
+      this.set(key, []);
+    }
+    return super.get(key);
+  }
+}
+
 class RemoteRunner {
   constructor(browser) {
     this.browser = browser;
-    this.handlers = {};
+    this.handlers = new ArrayMap();
+    this.onceHandlers = new ArrayMap();
     this.handleEvent = this.handleEvent.bind(this);
+    createMochaStatsCollector(this);
   }
 
-  on(name, handler) {
-    var handlers = this.handlers;
+  once(name, handler) {
+    this.onceHandlers.get(name).push(handler);
+  }
 
-    if (!handlers[name]) {
-      handlers[name] = [];
-    }
-    handlers[name].push(handler);
+  on(name, handler) {
+    this.handlers.get(name).push(handler);
   }
 
   async handleEvent(event) {
@@ -83,9 +94,12 @@ class RemoteRunner {
       };
       var obj = Object.assign({}, event.obj, additionalProps);
 
-      this.handlers[event.name].forEach(function (handler) {
-        handler(obj, event.err);
-      });
+      const triggerHandler = handler => handler(obj, event.err);
+
+      this.onceHandlers.get(event.name).forEach(triggerHandler);
+      this.onceHandlers.delete(event.name);
+
+      this.handlers.get(event.name).forEach(triggerHandler);
 
       switch (event.name) {
         case 'fail': this.handleFailed(); break;

bin/test-node.sh

@@ -37,17 +37,21 @@ fi
 if [ $PERF ]; then
     node tests/performance/index.js
 elif [ ! $COVERAGE ]; then
+    # --exit required to workaround #8839
     ./node_modules/.bin/mocha \
+        --exit \
         $BAIL_OPT \
         --timeout "$TIMEOUT" \
         --require=./tests/integration/node.setup.js \
         --reporter="$REPORTER" \
         --grep="$GREP" \
         $TESTS_PATH
 else
+    # --exit required to workaround #8839
     ./node_modules/.bin/istanbul cover \
        --no-default-excludes -x 'tests/**' -x 'node_modules/**' \
        ./node_modules/mocha/bin/_mocha -- \
+        --exit \
         $BAIL_OPT \
         --timeout "$TIMEOUT" \
         --require=./tests/integration/node.setup.js \

package.json

@@ -10,7 +10,7 @@
     "build-modules": "node bin/build-modules.js",
     "test-unit": "mocha tests/unit",
     "test-node": "./bin/test-node.sh",
-    "test-component": "mocha tests/component",
+    "test-component": "mocha --exit tests/component # --exit for #8839",
     "test-fuzzy": "TYPE=fuzzy npm run test",
     "test-browser": "npm run build-test && node ./bin/test-browser.js",
     "test-memleak": "mocha -gc tests/memleak",
@@ -90,7 +90,7 @@
     "marky": "1.2.0",
     "median": "0.0.2",
     "mkdirp": "0.5.1",
-    "mocha": "3.5.0",
+    "mocha": "10.2.0",
     "mockery": "2.1.0",
     "ncp": "2.0.0",
     "playwright": "1.36.1",