tests: remove commonUtils.Promise (#8776)

* simplifies code
* avoids including the `pouchdb-for-coverage` module unless it's explicitly required elsewhere - e.g. halves the LoC of `performance-bundle.js`

Author: alxndrsn

packages/node_modules/pouchdb-for-coverage/src/utils.js

@@ -52,7 +52,6 @@ export default {
   parseUri,
   uuid,
   rev,
-  Promise,
   atob,
   btoa,
   binaryStringToBlobOrBuffer,

tests/common-utils.js

@@ -124,7 +124,7 @@ commonUtils.loadPouchDBForBrowser = function (plugins) {
 
 // Thanks to http://engineeredweb.com/blog/simple-async-javascript-loader/
 commonUtils.asyncLoadScript = function (url) {
-  return new commonUtils.Promise(function (resolve, reject) {
+  return new Promise(function (resolve, reject) {
     // Create a new script and setup the basics.
     var script = document.createElement("script");
 
@@ -174,8 +174,4 @@ commonUtils.createDocId = function (i) {
   return 'doc_' + i.toString().padStart(10, '0');
 };
 
-var PouchForCoverage = require('../packages/node_modules/pouchdb-for-coverage');
-var pouchUtils = PouchForCoverage.utils;
-commonUtils.Promise = pouchUtils.Promise;
-
 module.exports = commonUtils;

tests/find/test-suite-1/test.basic.js

@@ -1,8 +1,6 @@
 'use strict';
 
 describe('test.basic.js', function () {
-  var Promise = testUtils.Promise;
-
   it('should create an index', function () {
     var db = context.db;
     var index = {

tests/find/test-suite-1/test.callbacks.js

@@ -1,8 +1,6 @@
 'use strict';
 
 describe('test.callbacks.js', function () {
-  var Promise = testUtils.Promise;
-
   it('should create an index', function () {
     var db = context.db;
     var index = {

tests/find/test-suite-1/test.explain.js

@@ -1,8 +1,6 @@
 'use strict';
 
 describe('test.explain.js', function () {
-  var Promise = testUtils.Promise;
-
   beforeEach(function () {
     var db = context.db;
     return db.bulkDocs([

tests/find/test-suite-2/test.kitchen-sink-2.js

@@ -18,7 +18,6 @@ describe('pouchdb-find: test.kitchen-sink-2.js', function () {
   }
 
   var dbName = testUtils.adapterUrl(testUtils.adapterType(), 'testdb');
-  var Promise = testUtils.Promise;
 
   this.timeout(100000);
 

tests/find/test-suite-2/test.kitchen-sink.js

@@ -102,11 +102,9 @@ function arrayRandom(arr) {
 
 describe('chaos-monkey', function () {
 
-  var Promise;
   var a, b;
 
   beforeEach(function (done) {
-    Promise = testUtils.Promise;
     var aname = testUtils.adapterUrl('local', 'testdb');
     var bname = testUtils.adapterUrl('http', 'test_repl_remote');
     testUtils.cleanup([aname, bname], function () {

tests/fuzzy/test.fuzzy.js

@@ -51,7 +51,7 @@ describe('migration', function () {
     return Promise.all(scenarios.map(function ({ scenario }) {
       var match = scenario.match(/PouchDB v([.\d]+)/);
       if (!match) {
-        return testUtils.Promise.resolve();
+        return Promise.resolve();
       }
 
       const loader = testUtils.asyncLoadScript('deps/pouchdb-' + match[1] + '-postfixed.js');
@@ -923,7 +923,7 @@ describe('migration', function () {
 
           var oldPouch = new dbs.first.pouch(
             dbs.first.local, dbs.first.localOpts);
-          var chain = testUtils.Promise.resolve();
+          var chain = Promise.resolve();
           tree.forEach(function (docs) {
             chain = chain.then(function () {
               return oldPouch.bulkDocs(docs, {new_edits: false});

tests/integration/browser.migration.js

@@ -92,7 +92,7 @@ describe.skip('browser.worker.js', function () {
     }
 
     // both threads agree the count is 0
-    return testUtils.Promise.all([
+    return Promise.all([
       db.allDocs().then(function (res) {
         res.total_rows.should.equal(0);
       }),
@@ -104,7 +104,7 @@ describe.skip('browser.worker.js', function () {
       return db.post({});
     }).then(function () {
       // both threads agree the count is 1
-      return testUtils.Promise.all([
+      return Promise.all([
         db.allDocs().then(function (res) {
           res.total_rows.should.equal(1);
         }),