New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Support pattern subscribe non-persistent topic. #207
Conversation
Great idea. Are there any other contexts that we need to use RegexSubscriptionMode except for this case in the Java client? Would it be possible also apply this solution to the Java client? |
There is no other case using
Yes, I'll start an email to discuss this. |
6498f13
to
5ac904e
Compare
After, we need to add a RegexSubscriptionMode config. PTAL. |
09e2871
to
6f93009
Compare
6f93009
to
8607653
Compare
Master Issue: #204
Motivation
The current default only lookup persistent topics on the namespace, We need to add
RegexSubscriptionMode
to control the lookup topics type.The Java client relate impl refer: apache/pulsar#2025
Modifications
RegexSubscriptionMode
to support pattern subscribeall/persistent only/non-persistent-only
topic.Verifying this change
TopicNameTest.testRemoveDomain
to cover the newly addedTopicName::removeDomain
method.TopicNameTest.testContainsDomain
to cover the newly addedTopicName::containsDomain
method.LookupServiceTest.basicGetNamespaceTopics
method to cover more get topics cases.ConsumerTest.testPatternSubscribeTopic
to cover use pattern subscribe topersistent topic
,non-persistent topic
, andall topic
.Documentation
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)