[ISSUE 10138] fix npe when new transaction #10139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Apr 5, 2021
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/PulsarClient.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
Outdated
Show resolved
Hide resolved
merlimat
approved these changes
Apr 5, 2021
315157973
approved these changes
Apr 6, 2021
codelipenghui
approved these changes
Apr 6, 2021
congbobo184
approved these changes
Apr 6, 2021
wangjialing218
pushed a commit
to wangjialing218/pulsar
that referenced
this pull request
Apr 9, 2021
* [pulsar client] fix npe when new transaction * add unit test * address suggestion Co-authored-by: linjunhua <linjh1@jiguang.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10138
Modifications
If transactions are not enabled, throw PulsarClientException when new transaction
Verifying this change
Add unit test