Fix issues in advanceNonDurableCursors #10667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have tests that exercise explicitly this code? |
merlimat
approved these changes
May 21, 2021
added 2 commits
May 21, 2021 12:41
|
@eolivelli yes in general but don't have a test to replicate this specific issue. Attempted to replicate issue in test but no a clear way how to |
added 3 commits
May 24, 2021 18:27
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
Co-authored-by: Jerry Peng <jerryp@splunk.com>
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 10, 2021
Co-authored-by: Jerry Peng <jerryp@splunk.com> (cherry picked from commit a244ed3)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Co-authored-by: Jerry Peng <jerryp@splunk.com>
Technoboy-
pushed a commit
that referenced
this pull request
Jul 5, 2022
Co-authored-by: Jerry Peng <jerryp@splunk.com>
|
Cherry-pick this to branch-2.7, because we need to cherry-pick #12602, it relies on this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are a couple of issues in advanceNonDurableCursors
This happens because highestPositionToDelete calculated when the reader/consumer is caught up is going to be higher than the last confirmed for the of the managed ledger. There is also no point in trying to advance the mark delete position if the reader/consumer is caught up.