Unlock the write lock of the UnAckedMessageTracker before call redeliverUnacknowledgedMessages #10768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verUnacknowledgedMessages The deadlock will happen in following steps: 1. The client internal thread got the consumer instance lock when call internalBatchReceiveAsync 2. The timer thread got the write lock of the UnAckedMessageTracker and then waiting on the consumer instance lock when call redeliverUnacknowledgedMessages 3. The client internal thread try to get the write lock of the UnAckedMessageTracker when adding unacked messages The deadlock happens. The fix is ensure the timer thread unlock the write lock before call redeliverUnacknowledgedMessages
codelipenghui
added
release/blocker
codelipenghui
requested review from
eolivelli,
jiazhai,
lhotari,
merlimat,
sijie,
315157973 and
hangc0276
|
Write lock is reentrant, why is it deadlock? Please correct me if I am wrong. |
|
@315157973 As described in the PR description, they are from different threads, one is the client internal thread, one is timer thread. |
315157973
approved these changes
Jun 1, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…verUnacknowledgedMessages (apache#10768) The deadlock will happen in following steps: 1. The client internal thread got the consumer instance lock when call internalBatchReceiveAsync 2. The timer thread got the write lock of the UnAckedMessageTracker and then waiting on the consumer instance lock when call redeliverUnacknowledgedMessages 3. The client internal thread try to get the write lock of the UnAckedMessageTracker when adding unacked messages The deadlock happens. The fix is ensure the timer thread unlock the write lock before call redeliverUnacknowledgedMessages
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…verUnacknowledgedMessages (apache#10768) The deadlock will happen in following steps: 1. The client internal thread got the consumer instance lock when call internalBatchReceiveAsync 2. The timer thread got the write lock of the UnAckedMessageTracker and then waiting on the consumer instance lock when call redeliverUnacknowledgedMessages 3. The client internal thread try to get the write lock of the UnAckedMessageTracker when adding unacked messages The deadlock happens. The fix is ensure the timer thread unlock the write lock before call redeliverUnacknowledgedMessages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10767
Motivation
The deadlock will happen in following steps:
The deadlock happens since the timer thread hold the write lock of the UnAckedMessageTracker
The fix is to ensure the timer thread unlock the write lock before call redeliverUnacknowledgedMessages