When topic does not exist, optimize the prompt message #10845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cckellogg
approved these changes
Jun 8, 2021
codelipenghui
approved these changes
Jun 8, 2021
codelipenghui
added
type/enhancement
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
### Motivation If we set enableRetry=true, the client will subscribe to the retry topic. If we set AllowAutoTopicCreation=false, the client will receive `Topic dose not exists`, which means that the retry Topic does not exists. This makes users very confused. My topic clearly exists, why is it still prompted like this? Therefore, the prompt information is improved to facilitate users to troubleshoot problems. ### Modifications add topic name to the returning message
codelipenghui
pushed a commit
that referenced
this pull request
Jun 25, 2021
### Motivation If we set enableRetry=true, the client will subscribe to the retry topic. If we set AllowAutoTopicCreation=false, the client will receive `Topic dose not exists`, which means that the retry Topic does not exists. This makes users very confused. My topic clearly exists, why is it still prompted like this? Therefore, the prompt information is improved to facilitate users to troubleshoot problems. ### Modifications add topic name to the returning message (cherry picked from commit e72a0d8)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation If we set enableRetry=true, the client will subscribe to the retry topic. If we set AllowAutoTopicCreation=false, the client will receive `Topic dose not exists`, which means that the retry Topic does not exists. This makes users very confused. My topic clearly exists, why is it still prompted like this? Therefore, the prompt information is improved to facilitate users to troubleshoot problems. ### Modifications add topic name to the returning message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If we set enableRetry=true, the client will subscribe to the retry topic.
If we set AllowAutoTopicCreation=false, the client will receive
Topic dose not exists, which means that the retry Topic does not exists.This makes users very confused. My topic clearly exists, why is it still prompted like this?
Therefore, the prompt information is improved to facilitate users to troubleshoot problems.
Modifications
add topic name to the returning message