[pulsar-client] Fix the wrong multi-topic has message available behavior #13634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot rerun-failure-checks |
Demogorgon314
force-pushed
the
fix/multi-topic-reader-has-message-available-behavior
branch
from
4d42722
to
df2ec0e
Compare
|
/pulsarbot rerun-failure-checks |
2 similar comments
|
/pulsarbot rerun-failure-checks |
|
/pulsarbot rerun-failure-checks |
|
Look like the flaky test is not relevant to this PR. If I understand correctly. |
|
/pulsarbot rerun-failure-checks |
codelipenghui
added
release/2.9.2
release/2.8.3
type/bug
codelipenghui
approved these changes
Jan 12, 2022
RobertIndie
approved these changes
Jan 12, 2022
2 tasks
Demogorgon314
deleted the
fix/multi-topic-reader-has-message-available-behavior
branch
codelipenghui
pushed a commit
that referenced
this pull request
Jan 18, 2022
Fixes #13605 ### Motivation Currently, the multiTopicReader `hasMessageAvailable` might get the wrong result, we must check `numMessagesInQueue() > 0` again after finish all consumer `hasMessageAvaliableAsync` future, bacause some message might already in `MultiTopicsConsumerImpl#incomingMessages`. ### Modifications * Fix the wrong multi-topic has message available behavior. * Use `reader.readNextAsync()` instead of block method `reader.readNext()`. * Reduce the units test running time by changing `MultiTopicsReaderTest` to use `@BeforeClass`, `@AfterClass`. (cherry picked from commit e57dc8f)
codelipenghui
pushed a commit
that referenced
this pull request
Jan 18, 2022
Fixes #13605 ### Motivation Currently, the multiTopicReader `hasMessageAvailable` might get the wrong result, we must check `numMessagesInQueue() > 0` again after finish all consumer `hasMessageAvaliableAsync` future, bacause some message might already in `MultiTopicsConsumerImpl#incomingMessages`. ### Modifications * Fix the wrong multi-topic has message available behavior. * Use `reader.readNextAsync()` instead of block method `reader.readNext()`. * Reduce the units test running time by changing `MultiTopicsReaderTest` to use `@BeforeClass`, `@AfterClass`. (cherry picked from commit e57dc8f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13605
Motivation
Currently, the multiTopicReader
hasMessageAvailablemight get the wrong result, we must checknumMessagesInQueue() > 0again after finish all consumerhasMessageAvaliableAsyncfuture, bacause some message might already inMultiTopicsConsumerImpl#incomingMessages.Modifications
reader.readNextAsync()instead of block methodreader.readNext().MultiTopicsReaderTestto use@BeforeClass,@AfterClass.Documentation
Need to update docs?
no-need-docThis is a bug fix, no need doc.