New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Kafka Source and Kafka Sink to Pulsar Connect #1557

Merged
merged 3 commits into from Apr 13, 2018

Conversation

Projects
None yet
3 participants
@srkukarni
Contributor

srkukarni commented Apr 12, 2018

Motivation

Explain here the context, and why you're making that change.
What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Result

After your change, what will change.

@srkukarni

This comment has been minimized.

Show comment
Hide comment
@srkukarni
Contributor

srkukarni commented Apr 12, 2018

@sijie

looks good. one comment about the kafka version.

Show outdated Hide outdated pom.xml Outdated
@sijie

sijie approved these changes Apr 12, 2018

@sijie sijie added this to the 2.0.0-incubating milestone Apr 12, 2018

@srkukarni

This comment has been minimized.

Show comment
Hide comment
@srkukarni

srkukarni Apr 12, 2018

Contributor

@merlimat I've standardized the versions used by both modules. Please take a look again. Thanks!

Contributor

srkukarni commented Apr 12, 2018

@merlimat I've standardized the versions used by both modules. Please take a look again. Thanks!

@srkukarni

This comment has been minimized.

Show comment
Hide comment
@srkukarni

srkukarni Apr 12, 2018

Contributor

retest this please

Contributor

srkukarni commented Apr 12, 2018

retest this please

@merlimat

👍

@merlimat merlimat merged commit 616e2a2 into apache:master Apr 13, 2018

3 checks passed

Jenkins: C++ / Python Tests SUCCESS
Details
Jenkins: Integration Tests SUCCESS
Details
Jenkins: Java 8 - Unit Tests SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment