New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed BatchMessageTest intermittent failures #1577

Merged
merged 1 commit into from Apr 14, 2018

Conversation

Projects
None yet
2 participants
@merlimat
Contributor

merlimat commented Apr 13, 2018

Motivation

This test became flaky after the delayed acks changed went it. Basically, with delayed acks, the backlog doesn't go to 0 immediately, only when the consumer sends the actually ack (by default within 100ms).

The acks are also flushed on consumer close, so after the close the backlog will be 0.

@merlimat merlimat added this to the 2.0.0-incubating milestone Apr 13, 2018

@merlimat merlimat self-assigned this Apr 13, 2018

@merlimat merlimat requested review from sijie and rdhabalia Apr 13, 2018

@sijie

sijie approved these changes Apr 14, 2018

@sijie sijie merged commit 2d4a350 into apache:master Apr 14, 2018

3 checks passed

Jenkins: C++ / Python Tests SUCCESS
Details
Jenkins: Integration Tests SUCCESS
Details
Jenkins: Java 8 - Unit Tests SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment