[refactor][client] Remove useless locks in batch receiving #18005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibd
force-pushed
the
remove_useless_lock
branch
from
a34b557
to
ef25f87
Compare
codelipenghui
added
area/client
type/refactor
codelipenghui
approved these changes
Oct 12, 2022
Jason918
approved these changes
Oct 12, 2022
Technoboy-
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the current implementation,
notifyPendingBatchReceivedCallBackmethod always runs oninternalPinnedExecutorthread, So, no need to use the lock to sync it.Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
shibd#19