Sources/Sinks can be launched using fat jars as well #3166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run cpp tests |
jerrypeng
reviewed
Dec 12, 2018
| @@ -120,39 +120,35 @@ void start() throws Exception { | |||
| if (builtInSource != null) { | |||
| sourceConfig.setArchive(builtInSource); | |||
| } | |||
| NarClassLoader classLoader; | |||
There was a problem hiding this comment.
does this mean we cannot run a built-in source or sink locally?
There was a problem hiding this comment.
Built-ins should be passed to the localrun with a proper file location, so they can be
jerrypeng
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Users should be able to just construct a fat jar for a Sources or a Sinks. While this capability existed in 2.2, subsequent cleanups removed the feature. This pr re-enables it.
Modifications
Describe the modifications you've done.
Result
After your change, what will change.