Fix the swagger files generated by removing troublesome class #4024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srkukarni
added
doc
merlimat
approved these changes
Apr 11, 2019
sijie
reviewed
Apr 11, 2019
| @@ -26,6 +26,8 @@ ROOT_DIR=$(git rev-parse --show-toplevel) | |||
| # so that Pdoc can import the module | |||
| find $ROOT_DIR -name CMakeCache.txt | xargs rm -f | |||
| find $ROOT_DIR -name CMakeFiles | xargs rm -rf | |||
| find $ROOT_DIR -name PulsarApi.pb.h | xargs rm -rf | |||
There was a problem hiding this comment.
are these 2 lines related to swagger?
There was a problem hiding this comment.
Not directly related to swagger, but these impede the building of the website.
|
rerun cpp tests |
|
rerun java8 tests |
1 similar comment
|
rerun java8 tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Function/Source/Sink get returns Function/Source/SinkConfig. Corrected the classname. This dramatically reduces the swagger defn generated for functions/sinks/sources.
Also removed a generated file swagger.json from sourcecode.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation