Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shade additional dependencies in java-instance.jar #4356

Merged
merged 2 commits into from May 24, 2019
Merged

shade additional dependencies in java-instance.jar #4356

merged 2 commits into from May 24, 2019

Conversation

jerrypeng
Copy link
Contributor

Motivation

Some dependencies are not shaded in the java-instance.jar. Probably leaked into the JAR via other dependencies.

@jerrypeng jerrypeng added this to the 2.4.0 milestone May 23, 2019
@jerrypeng jerrypeng self-assigned this May 23, 2019
merlimat
merlimat approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jerrypeng
Copy link
Contributor Author

rerun java8 tests

@jerrypeng
Copy link
Contributor Author

rerun cpp tests

@jerrypeng
Copy link
Contributor Author

rerun java8 tests

@jerrypeng
Copy link
Contributor Author

rerun java8 tests

2 similar comments
@jerrypeng
Copy link
Contributor Author

rerun java8 tests

@jerrypeng
Copy link
Contributor Author

rerun java8 tests

@jerrypeng jerrypeng merged commit 7cadc93 into apache:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@sijie sijie sijie approved these changes

@srkukarni srkukarni srkukarni approved these changes

Assignees

@jerrypeng jerrypeng

Labels
area/function
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jerrypeng @merlimat @sijie @srkukarni