Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[zookeeper] bump zookeeper to version 3.5.6 #5043
With zookeeper 3.5.5 now marked as stable and 3.5 being reccomend for
Pulsar previously had 3.5.x support but was downgraded due to concerns
As a follow on to this work, we should introduce new configuration options to support TLS connections to ZK, however, that is out of scope for this initial dependency bump.
Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
There are some references to ZK 3.4 versions of docs that may need updated to 3.5 eventually. Assuming this is accepted, we should make a follow on item to change those
1 similar comment
sijie left a comment
@merlimat @addisonj I remembered that there were some changes we made when downgrading zk to 3.4.x. Do we need to remove those hacks if there were (can't remember exactly what was the changes). There are problems in 3.5 when handling empty snapshots. I think we should clarify the situations in release notes or upgrade guide (we now have an upgrade guide, we should add the notes to it if it requires end-users' attentions).
I ran into the aforementioned upgrade issue with empty snapshots, but as I mentioned in PR, I had thought it might make sense to do a follow up for docs. As far as the hacks, I assume it may make sense to keep them around for some period of time for those who don't use embedded zookeeper and are sticking around 3.4?
This still seems to be failing tests as well (though they didn't run fine for locally...) but it seems to be pretty unlucky if it is just flaky.
Sorry that I missed your comment before. But since this is related to upgrade guide, can you please create a github issue and link the issue here? We have to mark that issue as a blocker for releasing 2.5.0.
I think the hack was done using AspectJ to inject
2 similar comments
1 similar comment
Yes, and it includes fix for upgrading ZK with missing snapshot:
With zookeeper 3.5.x now marked as stable and 3.5 being reccomend for the production branch (see https://zookeeper.apache.org/releases.html), this moves pulsar up to 3.5.6. Pulsar previously had 3.5.x support but was downgraded due to concerns of 3.5 still being a "beta", so this is a fairly simple change This also uses 3.5.6 as it has a fix for an issue where upgrades fail if there is no snapshot files Fixes #4448