Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cpp] Fixed negative ack tracker constructor sequence #5453

Merged
merged 4 commits into from
Oct 25, 2019
Merged

[Cpp] Fixed negative ack tracker constructor sequence #5453

merged 4 commits into from
Oct 25, 2019

Conversation

merlimat
Copy link
Contributor

Motivation

Negative ack tracker can leave the timerInterval_ not properly initialized given the initialization sequence. When that happens, the timer interval is set to garbage value and the task won't be triggered.

@merlimat merlimat added the type/bug The PR fixed a bug or issue reported a bug label Oct 23, 2019
@merlimat merlimat added this to the 2.4.2 milestone Oct 23, 2019
@merlimat merlimat self-assigned this Oct 23, 2019
hrsakai
hrsakai approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@hrsakai hrsakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hrsakai
Copy link
Contributor

hrsakai commented Oct 23, 2019

rerun cpp tests

@merlimat
Copy link
Contributor Author

run cpp tests
run integration tests

@sijie
Copy link
Member

sijie commented Oct 24, 2019

run cpp tests

@jiazhai
Copy link
Member

jiazhai commented Oct 24, 2019

@merlimat Thanks for the fix.
seems ci failed with check-format

-- Build files have been written to: /pulsar/pulsar-client-cpp
Scanning dependencies of target check-format
clang-format checks failed, run 'make format' to fix
CMakeFiles/check-format.dir/build.make:57: recipe for target 'CMakeFiles/check-format' failed

@merlimat
Copy link
Contributor Author

run java8 tests

1 similar comment
@jiazhai
Copy link
Member

jiazhai commented Oct 25, 2019

run java8 tests

@aahmed-se aahmed-se merged commit 6f113f7 into apache:master Oct 25, 2019
wolfstudy pushed a commit that referenced this pull request Nov 20, 2019
@merlimat @wolfstudy
[Cpp] Fixed negative ack tracker constructor sequence (#5453)
37c093e 
* [Cpp] Fixed negative ack tracker constructor sequence

* Fixed formatting

* Fixed default for neg ack delay on partitioned topics

* Fixed format

(cherry picked from commit 6f113f7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@jiazhai jiazhai jiazhai approved these changes

@hrsakai hrsakai hrsakai approved these changes

@ivankelly ivankelly Awaiting requested review from ivankelly

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@massakam massakam Awaiting requested review from massakam

Assignees

@merlimat merlimat

Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@merlimat @hrsakai @sijie @jiazhai @aahmed-se