Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose lastExpireTimestamp for subscription stats. #5721

Merged
merged 3 commits into from Nov 22, 2019

Conversation

@codelipenghui
Copy link
Contributor

codelipenghui commented Nov 21, 2019

Motivation

Expose lastExpireTimestamp for subscription stats. Can be used to troubleshooting TTL related issues

Verifying this change

Added new unit tests

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
@codelipenghui codelipenghui requested review from merlimat, jiazhai and sijie Nov 21, 2019
@codelipenghui codelipenghui self-assigned this Nov 21, 2019
@codelipenghui codelipenghui added this to the 2.4.3 milestone Nov 21, 2019
@sijie
sijie approved these changes Nov 21, 2019
@sijie

This comment has been minimized.

Copy link
Contributor

sijie commented Nov 21, 2019

retest this please

sijie added 2 commits Nov 21, 2019
…time
@sijie

This comment has been minimized.

Copy link
Contributor

sijie commented Nov 21, 2019

run cpp tests
run java8 tests

@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Nov 22, 2019

run java8 tests

1 similar comment
@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Nov 22, 2019

run java8 tests

@sijie sijie merged commit 2bbb10c into apache:master Nov 22, 2019
3 checks passed
3 checks passed
Jenkins: C++ / Python Tests SUCCESS
Details
Jenkins: Integration Tests SUCCESS
Details
Jenkins: Java 8 - Unit Tests SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.