Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reader builder clone error #5923

Merged
merged 2 commits into from Jan 3, 2020
Merged

Fix reader builder clone error #5923

merged 2 commits into from Jan 3, 2020

Conversation

@jiazhai
Copy link
Member

jiazhai commented Dec 23, 2019

Motivation

In reader builder, clone() method does not clone the config, and will cause error once we call a builder.clone() concurrently to create readers. This PR mainly try to fix this issue.

Modifications

  • use conf.clone(), to make sure conf is cloned.
  • add test to verify it.
  • fix other small issues, like get() methods, and access level, make it align with consumer/producer builder.

Verifying this change

ut passed.

@jiazhai jiazhai self-assigned this Dec 23, 2019
@jiazhai

This comment has been minimized.

Copy link
Member Author

jiazhai commented Dec 24, 2019

run java8 tests
run integration tests

@sijie
sijie approved these changes Dec 24, 2019
@jiazhai

This comment has been minimized.

Copy link
Member Author

jiazhai commented Dec 24, 2019

run java8 tests

unrelated tests:

org.apache.pulsar.client.api.BrokerServiceLookupTest.testSplitUnloadLookupTest
org.apache.pulsar.client.api.v1.V1_ProducerConsumerTest.testConcurrentConsumerReceiveWhileReconnect
org.apache.pulsar.io.PulsarFunctionE2ETest.testPulsarFunctionStats
@jiazhai

This comment has been minimized.

Copy link
Member Author

jiazhai commented Dec 25, 2019

run java8 tests

org.apache.pulsar.broker.service.PersistentFailoverE2ETest.testSimpleConsumerEventsWithoutPartition
org.apache.pulsar.client.api.BrokerServiceLookupTest.testModularLoadManagerSplitBundle
@jiazhai

This comment has been minimized.

Copy link
Member Author

jiazhai commented Dec 25, 2019

run java8 tests

org.apache.pulsar.client.api.v1.V1_ProducerConsumerTest.testConcurrentConsumerReceiveWhileReconnect
org.apache.pulsar.client.api.v1.V1_ProducerConsumerTest.testConcurrentConsumerReceiveWhileReconnect
org.apache.pulsar.client.api.v1.V1_ProducerConsumerTest.testConcurrentConsumerReceiveWhileReconnect
org.apache.pulsar.client.impl.BrokerClientIntegrationTest.testUnsupportedBatchMessageConsumer

@jiazhai

This comment has been minimized.

Copy link
Member Author

jiazhai commented Dec 25, 2019

run java8 tests

org.apache.pulsar.broker.service.BacklogQuotaManagerTest.setup
org.apache.pulsar.client.api.MessageDispatchThrottlingTest.setup
org.apache.pulsar.client.api.SimpleProducerConsumerTest.setup
org.apache.pulsar.websocket.proxy.ProxyConfigurationTest.setup

@jiazhai

This comment has been minimized.

Copy link
Member Author

jiazhai commented Dec 26, 2019

run java8 tests

org.apache.pulsar.client.impl.schema.KeyValueSchemaInfoTest.encodeDecodeNestedKeyValueSchemaInfo
org.apache.pulsar.client.impl.schema.KeyValueSchemaInfoTest.encodeDecodeNestedKeyValueSchemaInfo
org.apache.pulsar.client.impl.schema.KeyValueSchemaInfoTest.encodeDecodeNestedKeyValueSchemaInfo
org.apache.pulsar.client.impl.schema.KeyValueSchemaInfoTest.testKeyValueSchemaInfoToString
@jiazhai

This comment has been minimized.

Copy link
Member Author

jiazhai commented Dec 28, 2019

run java8 tests

@jiazhai

This comment has been minimized.

Copy link
Member Author

jiazhai commented Dec 29, 2019

run java8 tests

for error
org.apache.pulsar.broker.admin.v1.V1_AdminApiTest.setup

@jiazhai

This comment has been minimized.

Copy link
Member Author

jiazhai commented Dec 30, 2019

run java8 tests

@jiazhai

This comment has been minimized.

Copy link
Member Author

jiazhai commented Jan 2, 2020

run java8 tests
run integration tests

@jiazhai

This comment has been minimized.

Copy link
Member Author

jiazhai commented Jan 2, 2020

run java8 tests
run integration tests

Test Result (2 failures / -3)
org.apache.pulsar.client.impl.schema.PrimitiveSchemaTest.allSchemasShouldRoundtripInput
org.apache.pulsar.client.impl.schema.PrimitiveSchemaTest.allSchemasShouldSupportNull

@jiazhai

This comment has been minimized.

Copy link
Member Author

jiazhai commented Jan 2, 2020

run java8 tests
run integration tests

Test Result (1 failure / +1)
org.apache.pulsar.broker.loadbalance.SimpleLoadManagerImplTest.setup

@jiazhai

This comment has been minimized.

Copy link
Member Author

jiazhai commented Jan 3, 2020

run java8 tests

2 similar comments
@jiazhai

This comment has been minimized.

Copy link
Member Author

jiazhai commented Jan 3, 2020

run java8 tests

@jiazhai

This comment has been minimized.

Copy link
Member Author

jiazhai commented Jan 3, 2020

run java8 tests

@jiazhai

This comment has been minimized.

Copy link
Member Author

jiazhai commented Jan 3, 2020

run java8 tests

org.apache.pulsar.broker.admin.AdminApiTlsAuthTest.setup
org.apache.pulsar.client.api.DispatcherBlockConsumerTest.setup

@jiazhai jiazhai merged commit 88fc454 into apache:master Jan 3, 2020
15 of 18 checks passed
15 of 18 checks passed
backwards-compatibility backwards-compatibility
Details
unit-test-flaky unit-test-flaky
Details
unit-tests unit-tests
Details
cpp-tests
Details
cli
Details
function-state
Details
messaging
Details
process
Details
schema
Details
sql
Details
standalone
Details
thread
Details
tiered-filesystem
Details
tiered-jcloud
Details
License check
Details
Jenkins: C++ / Python Tests SUCCESS
Details
Jenkins: Integration Tests SUCCESS
Details
Jenkins: Java 8 - Unit Tests SUCCESS
Details
@sijie sijie added the release/2.4.3 label Jan 22, 2020
@sijie sijie added this to the 2.6.0 milestone Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.