Make ZkBookieRackAffinityMapping work as expected #6917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiazhai
approved these changes
May 8, 2020
codelipenghui
approved these changes
May 8, 2020
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
3 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
@sijie Seems the test failure is related with this change: |
jiazhai
reviewed
May 12, 2020
| if (biOpt.isPresent()) { | ||
| bi = biOpt.get(); | ||
| } else { | ||
| updateRacksWithHost(racksWithHost); |
There was a problem hiding this comment.
Do we need to update it here? seems this is a get operation, If it is not present, there is no need to update?
|
would like to remove it out of 2.5.2 |
sijie
added
component/storage
type/bug
|
@jiazhai: fix the comment. the BookiesRackConfiguration expects the key to be |
sijie
added a commit
to streamnative/pulsar-archived
that referenced
this pull request
May 26, 2020
### Motivation The current bookie rack affinity logic is problematic. The rack map is expecting a `host:port` pair but the bookkeeper DNS resolver is expecting a hostname or a host address. ### Modification - Introduce a new HashMap to keep a mapping between hostname and bookie info. It maintains the mapping for bookkeeper DNS resolver to lookup the network location.
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
May 27, 2020
### Motivation The current bookie rack affinity logic is problematic. The rack map is expecting a `host:port` pair but the bookkeeper DNS resolver is expecting a hostname or a host address. ### Modification - Introduce a new HashMap to keep a mapping between hostname and bookie info. It maintains the mapping for bookkeeper DNS resolver to lookup the network location.
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
### Motivation The current bookie rack affinity logic is problematic. The rack map is expecting a `host:port` pair but the bookkeeper DNS resolver is expecting a hostname or a host address. ### Modification - Introduce a new HashMap to keep a mapping between hostname and bookie info. It maintains the mapping for bookkeeper DNS resolver to lookup the network location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current bookie rack affinity logic is problematic. The rack map is expecting a
host:portpair but the bookkeeper DNS resolver is expecting a hostname or a host address.Modification
Verification
I have verified it worked well in setting up rackware placement policy.