New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tenant name check in list namespaces function. #7369
Conversation
/pulsarbot run-failure-checks |
1 similar comment
/pulsarbot run-failure-checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me, could you please add some unit tests for the change?
@codelipenghui Done. |
/pulsarbot run-failure-checks |
1 similar comment
/pulsarbot run-failure-checks |
merge from apache pulsar
/pulsarbot run-failure-checks |
// check the tenant name is valid | ||
namespaces.getTenantNamespaces(this.testTenant + "/default"); | ||
fail("should have failed"); | ||
} catch (RestException e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to catch the specific RestException or check the response code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
/pulsarbot run-failure-checks |
1 similar comment
/pulsarbot run-failure-checks |
fix [apache#7301 (cherry picked from commit 2b94d02)
fix #7301