Allow disabling HTTP TRACE/TRACK verbs #7907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 26, 2020 09:38
…eHttpTraceMethod and disableHttpTrackMethod are set to true
rdhabalia
approved these changes
Aug 26, 2020
sijie
approved these changes
Aug 27, 2020
|
@wmccarley can you please rebase the PR. |
codelipenghui
approved these changes
Nov 4, 2020
|
@wmccarley Could you please resolve the conflicts? |
|
move to 2.8.0 first |
jiazhai
approved these changes
Dec 15, 2020
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
### Motivation *Pulsar broker's embedded Jetty client does not disable HTTP TRACE and TRACK by default which causes the application to be flagged as insecure in certain corporate environments* ### Modifications *Created a new servlet filter: DisableDebugHttpMethodFilter that is attached to the servlets as they are added at startup. I used [this StackOverflow answer](https://stackoverflow.com/a/40990957)* for reference.
|
currently which branch fixed this？ |
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation *Pulsar broker's embedded Jetty client does not disable HTTP TRACE and TRACK by default which causes the application to be flagged as insecure in certain corporate environments* ### Modifications *Created a new servlet filter: DisableDebugHttpMethodFilter that is attached to the servlets as they are added at startup. I used [this StackOverflow answer](https://stackoverflow.com/a/40990957)* for reference.
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Pulsar broker's embedded Jetty client does not disable HTTP TRACE and TRACK by default which causes the application to be flagged as insecure in certain corporate environments
Modifications
Created a new servlet filter: DisableDebugHttpMethodFilter that is attached to the servlets as they are added at startup. I used this StackOverflow answer for reference.
Verifying this change
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
Documentation