Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Swagger to 1.6.2 and Maven Swagger Plugin to 3.1.7 #8845

Merged
merged 4 commits into from Dec 9, 2020

Conversation

eolivelli
Copy link
Contributor

Motivation

In out build environment (MagNews.com) we are upgrading Swagger to 1.6.2, as it is also used by Pulsar Builder system we would like to upgrade Swagger here as well.
Even if Swagger is used for documentation, swagger-core is a runtime dependency so it is better to guarantee that Pulsar is working well with latest version of Swagger 1.X.

I am also upgrading the Maven Swagger Plugin to 3.1.7, the 3.1.8 is buggy and it fails the build with NPE (the same problem occurs even in MagNews build, so it is not related to Pulsar itself)

Modifications

  • Upgrade Swagger version to 1.6.2
  • Upgrade Maven Plugin to 3.1.7

Describe the modifications you've done.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no
  • The rest endpoints: no (not directly, but swagger-core is a runtime dependency for the REST endpoint)
  • The admin cli options: no
  • Anything that affects deployment: no

Documentation

  • Does this pull request introduce a new feature? no

@sijie sijie added this to the 2.8.0 milestone Dec 7, 2020
@Jennifer88huang-zz
Copy link
Contributor

/pulsarbot run-failure-checks

@eolivelli
Copy link
Contributor Author

@codelipenghui this patch is good to go :-)
all tests passed

@sijie sijie merged commit 9953129 into apache:master Dec 9, 2020
zymap pushed a commit to zymap/pulsar that referenced this pull request Dec 10, 2020
### Motivation

In out build environment (MagNews.com) we are upgrading Swagger to 1.6.2, as it is also used by Pulsar Builder system we would like to upgrade Swagger here as well.
Even if Swagger is used for documentation, swagger-core is a runtime dependency so it is better to guarantee that Pulsar is working well with latest version of Swagger 1.X.

I am also upgrading the Maven Swagger Plugin to 3.1.7, the 3.1.8 is buggy and it fails the build with NPE (the same problem occurs even in MagNews build, so it is not related to Pulsar itself)

### Modifications
- Upgrade Swagger version to 1.6.2
- Upgrade Maven Plugin to 3.1.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants