fix BKIncorrectParameterException

[aloyszhang]

Fixes #9090

Motivation

This PR add pre-condition before read entry from BookKeeper to fix BKIncorrectParameterException

[eolivelli]

+1

[eolivelli]

Using instanceof is a bad practice, not Object oriented.

It is not in the scope of this PR but it would be better to have a more OO approach, using polymorphism

[aloyszhang]

Agree with you that instanceof is not a good practice if we have a better choice.
There are two class AppendIndexMetadataInterceptor and AppendBrokerTimestampMetadataInterceptor implement BrokerEntryMetadataInterceptor.
If using polymorphism, for AppendBrokerTimestampMetadataInterceptor, its recoveryIndexGenerator method do nothing like

public void recoveryIndexGenerator(long index) {
       // do nothing.
    }

And the new onManagedLedgerLastLedgerInitialize would be like

  @Override
    public void onManagedLedgerLastLedgerInitialize(String name, LedgerHandle lh) {
        try {
            for (BrokerEntryMetadataInterceptor interceptor : brokerEntryMetadataInterceptors) {
                if (lh.getLastAddConfirmed() >= 0) {
                    LedgerEntries ledgerEntries =
                            lh.read(lh.getLastAddConfirmed(), lh.getLastAddConfirmed());
                    for (LedgerEntry entry : ledgerEntries) {
                        PulsarApi.BrokerEntryMetadata brokerEntryMetadata =
                                Commands.parseBrokerEntryMetadataIfExist(entry.getEntryBuffer());
                        if (brokerEntryMetadata != null && brokerEntryMetadata.hasIndex()) {
                                    interceptor.recoveryIndexGenerator(brokerEntryMetadata.getIndex());
                        }
                    }

                }
            }
        } catch (org.apache.bookkeeper.client.api.BKException | InterruptedException e) {
            log.error("[{}] Read last entry error.", name, e);
        }
    }

So , even if interceptor is a AppendBrokerTimestampMetadataInterceptor, we still need to read the last entry from BookKeeper and deserialize BrokerEntryMetadata from the entry.
https://github.com/aloyszhang/pulsar/blob/recovery-index/pulsar-broker/src/main/java/org/apache/pulsar/broker/intercept/ManagedLedgerInterceptorImpl.java#L87~L92

LedgerEntries ledgerEntries =
                            lh.read(lh.getLastAddConfirmed(), lh.getLastAddConfirmed());
                    for (LedgerEntry entry : ledgerEntries) {
                        PulsarApi.BrokerEntryMetadata brokerEntryMetadata =
                                Commands.parseBrokerEntryMetadataIfExist(entry.getEntryBuffer());
                        if (brokerEntryMetadata != null && brokerEntryMetadata.hasIndex()) {

[aloyszhang]

/pulsarbot run-failure-checks

[aloyszhang]

/pulsarbot run-failure-checks

[aloyszhang]

/pulsarbot run-failure-checks

[aloyszhang]

/pulsarbot run-failure-checks

[aloyszhang]

/pulsarbot run-failure-checks

[codelipenghui]

@aloyszhang please rebase the master branch

[aloyszhang]

/pulsarbot run-failure-checks