Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] add listenerName support to client-cpp #9119

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

z2665
Copy link
Contributor

@z2665 z2665 commented Jan 4, 2021

Motivation

since pulsar 2.6.1 java client support the listenerName to support access pular server with advertisedListeners
but client-cpp not support

Modifications

  1. add setListenerName/getListenerName to ClientConfiguration
  2. add ListenerName to TopicLookup in BinaryProtoLookupService

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@sijie
Copy link
Member

sijie commented Jan 4, 2021

@BewareMyPower Can you review this pull request?

@jiazhai
Copy link
Member

jiazhai commented Jan 5, 2021

@z2665 Please help check the CPP CI error: https://github.com/apache/pulsar/pull/9119/checks?check_run_id=1645434731

@BewareMyPower
Copy link
Contributor

/pulsarbot run-failure-checks

@BewareMyPower
Copy link
Contributor

@jiazhai BasicEndToEndTest.testLookupThrottling is a flaky test which is hard to reproduce in local environment but easily to happen in CI environment.

Copy link
Contributor

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiazhai
Copy link
Member

jiazhai commented Jan 5, 2021

/pulsarbot run-failure-checks

@sijie sijie merged commit 7d7feb3 into apache:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants