Fix fake complete issue in offloading #9306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Renkai <gaelookair@gmail.com>
Signed-off-by: Renkai <gaelookair@gmail.com>
sijie
approved these changes
Jan 25, 2021
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
codelipenghui
pushed a commit
that referenced
this pull request
Jan 26, 2021
### Motivation In our current code, complete in offloading context may set true even sync metadata to Zookeeper failed, which may lead to more fatal error like data in Bookkeeper will be deleted but other managed ledger will see data not offloaded and try to read from Bookkeeper. ### Modification This PR make sure local ledger info will be updated after Zookeeper updated. * prevent ledgers info change without write to zk succeed * add unit test to prevent fake positive when offload failed (cherry picked from commit 3c22b47)
codelipenghui
added a commit
that referenced
this pull request
Jan 26, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Jan 26, 2021
### Motivation In our current code, complete in offloading context may set true even sync metadata to Zookeeper failed, which may lead to more fatal error like data in Bookkeeper will be deleted but other managed ledger will see data not offloaded and try to read from Bookkeeper. ### Modification This PR make sure local ledger info will be updated after Zookeeper updated. * prevent ledgers info change without write to zk succeed * add unit test to prevent fake positive when offload failed (cherry picked from commit 3c22b47)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our current code,
completein offloading context may set true even sync metadata to Zookeeper failed, which may lead to more fatal error like data in Bookkeeper will be deleted but other managed ledger will see data not offloaded and try to read from Bookkeeper.This PR make sure local ledger info will be updated after Zookeeper updated.