Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redelivery rates to Consumer and Subscription stats #95

Merged
merged 1 commit into from
Nov 1, 2016

Conversation

sschepens
Copy link
Contributor

Motivation

It could be very useful to know how many messages are being redelivered by a subscription and its consumers.

Modifications

Added msgRateRedeliver to Subscription and Consumer stats

Result

One can now know the rates of redelivery

@yahoocla
Copy link

CLA is valid!

@merlimat merlimat added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Oct 31, 2016
@merlimat merlimat added this to the 1.16 milestone Oct 31, 2016
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sschepens
Copy link
Contributor Author

Added aggregated unAckedMessages count for a subscription as well

@merlimat merlimat merged commit 5e55d79 into apache:master Nov 1, 2016
@sschepens sschepens deleted the redeliver_stats branch November 1, 2016 17:42
sijie pushed a commit to sijie/pulsar that referenced this pull request Mar 4, 2018
hrsakai pushed a commit to hrsakai/pulsar that referenced this pull request Dec 10, 2020
hangc0276 pushed a commit to hangc0276/pulsar that referenced this pull request May 26, 2021
Fix apache#95.
Make Kafka OffsetCommit and Pulsar backlog align.

Add backlog tracker in GroupCoordinator.
After fetch message, ack the fetched position.

* pass tests
* add consumer when sync group
* change log level bacck
* ignore testSessionTimeout, and opened new issue to track this
* bin/kop was accidently deleted, add it back
* remove LOOKUP_CACHE when protocol close
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants