Fixed wait-for-exclusive producer triggering of operation timeout #9600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
requested review from
sijie,
srkukarni,
rdhabalia,
jerrypeng and
codelipenghui
jerrypeng
approved these changes
Feb 16, 2021
codelipenghui
approved these changes
Feb 17, 2021
sijie
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The timeout operation when waiting for exclusive producer is not being handled correctly. This leads to the client finally discarding the notification from the broker that it has become the new exclusive producer.
The test was masking this issue because it wasn't using the ad-hoc client instance with the reduced operation timeout.