[client] Add BouncyCastleProvider as security provider to prevent NPE #9601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If we enable end-to-end encryption of messages on the client side, the following NPE may occur and encryption may fail.
This is because
BouncyCastleProvider
is not available and fails to get theCipher
instance on the following line:pulsar/pulsar-client-messagecrypto-bc/src/main/java/org/apache/pulsar/client/impl/crypto/MessageCryptoBc.java
Line 144 in 2fd878a
Modifications
We can avoid this problem by adding
BouncyCastleProvider
as a security provider in the static initializer ofMessageCryptoBc
.