Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MaxUnackedMessagesPerConsumer cannot be changed dynamically and cannot be disabled #9657

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

315157973
Copy link
Contributor

@315157973 315157973 commented Feb 20, 2021

Motivation

  1. The MaxUnackedMessagesPerConsumer cannot be changed dynamically now. When the policy is modified, only the newly created consumer can use the new policy. The previously created consumer still uses the old policy.
    It is very difficult to restart consumers in the online environment.
  2. This policy cannot be disabled.

Modifications

  1. Change int to Integer, so that we can judge whether the namespace-level has a policy
  2. The maxUnackedMessages in the consumer is changed to non-final, and this value is also updated when the policy is updated

@sijie sijie added this to the 2.8.0 milestone Feb 22, 2021
@codelipenghui codelipenghui merged commit 7001f64 into apache:master Feb 22, 2021
@315157973 315157973 deleted the maxunackPerConsumer branch February 23, 2021 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants