Fix Pulsar SQL query compression data #9663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
requested review from
merlimat,
jerrypeng,
srkukarni,
315157973,
hangc0276,
jiazhai,
sijie and
zymap
codelipenghui
added
type/bug
sijie
approved these changes
Feb 22, 2021
|
+1 on this, facing same issue working with presto connector. |
MarvinCai
reviewed
May 7, 2021
| @@ -94,7 +94,7 @@ public static void parseMessage(TopicName topicName, long ledgerId, long entryId | |||
| throw new IOException("Cannot parse encrypted message " + msgMetadata + " on topic " + topicName); | |||
| } | |||
|
|
|||
| uncompressedPayload = uncompressPayloadIfNeeded(topicName, msgMetadata, headersAndPayload, ledgerId, | |||
| uncompressedPayload = uncompressPayloadIfNeeded(topicName, msgMetadata, headersAndPayload.retain(), ledgerId, | |||
There was a problem hiding this comment.
Probably better to let ReferenceCountedMessageMetadata do both retain and release, else caller forget to call retain might cause trouble when ReferenceCountedMessageMetadata try to do release.
There was a problem hiding this comment.
Good point, updated.
merlimat
added
the
release/blocker
(cherry picked from commit 5ff2c0033684a3fcdb56dae9ddf5545452f2ee75)
codelipenghui
force-pushed
the
penghui/fix-sql-compression
branch
from
0f8ec13
to
2362dd3
Compare
|
/pulsarbot run-failure-checks |
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
### Motivation In the master branch, If enable data compression, Pulsar SQL will occurs following errors: ``` io.netty.util.IllegalReferenceCountException: refCnt: 0 at io.netty.buffer.AbstractByteBuf.ensureAccessible(AbstractByteBuf.java:1489) at io.netty.buffer.AbstractByteBuf.checkIndex(AbstractByteBuf.java:1418) at io.netty.buffer.AbstractPooledDerivedByteBuf$PooledNonRetainedSlicedByteBuf.slice(AbstractPooledDerivedByteBuf.java:298) at org.apache.pulsar.common.api.proto.MessageMetadata.getSchemaVersionSlice(MessageMetadata.java:545) at org.apache.pulsar.common.api.proto.MessageMetadata.getSchemaVersion(MessageMetadata.java:535) at org.apache.pulsar.common.api.raw.RawMessageImpl.getSchemaVersion(RawMessageImpl.java:147) at org.apache.pulsar.sql.presto.PulsarRecordCursor.advanceNextPosition(PulsarRecordCursor.java:454) at io.prestosql.spi.connector.RecordPageSource.getNextPage(RecordPageSource.java:90) at io.prestosql.operator.TableScanOperator.getOutput(TableScanOperator.java:302) at io.prestosql.operator.Driver.processInternal(Driver.java:379) at io.prestosql.operator.Driver.lambda$processFor$8(Driver.java:283) at io.prestosql.operator.Driver.tryWithLock(Driver.java:675) at io.prestosql.operator.Driver.processFor(Driver.java:276) at io.prestosql.execution.SqlTaskExecution$DriverSplitRunner.processFor(SqlTaskExecution.java:1075) at io.prestosql.execution.executor.PrioritizedSplitRunner.process(PrioritizedSplitRunner.java:163) at io.prestosql.execution.executor.TaskExecutor$TaskRunner.run(TaskExecutor.java:484) at io.prestosql.$gen.Presto_332__testversion____20210221_151218_2.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) ``` ### Modifications 1. Retain the original buffer for RawMessage metadata peek since we reuse the data buffer to get the schema version etc. 2. Release the original data buffer while deallocating the `ReferenceCountedMessageMetadata.java` ### Verifying this change Unit test added. Integration test added. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (no) - The public API: (no) - The schema: (no) - The default values of configurations: (no) - The wire protocol: (no) - The rest endpoints: (no) - The admin cli options: (no) - Anything that affects deployment: (no) ### Documentation - Does this pull request introduce a new feature? (no)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation In the master branch, If enable data compression, Pulsar SQL will occurs following errors: ``` io.netty.util.IllegalReferenceCountException: refCnt: 0 at io.netty.buffer.AbstractByteBuf.ensureAccessible(AbstractByteBuf.java:1489) at io.netty.buffer.AbstractByteBuf.checkIndex(AbstractByteBuf.java:1418) at io.netty.buffer.AbstractPooledDerivedByteBuf$PooledNonRetainedSlicedByteBuf.slice(AbstractPooledDerivedByteBuf.java:298) at org.apache.pulsar.common.api.proto.MessageMetadata.getSchemaVersionSlice(MessageMetadata.java:545) at org.apache.pulsar.common.api.proto.MessageMetadata.getSchemaVersion(MessageMetadata.java:535) at org.apache.pulsar.common.api.raw.RawMessageImpl.getSchemaVersion(RawMessageImpl.java:147) at org.apache.pulsar.sql.presto.PulsarRecordCursor.advanceNextPosition(PulsarRecordCursor.java:454) at io.prestosql.spi.connector.RecordPageSource.getNextPage(RecordPageSource.java:90) at io.prestosql.operator.TableScanOperator.getOutput(TableScanOperator.java:302) at io.prestosql.operator.Driver.processInternal(Driver.java:379) at io.prestosql.operator.Driver.lambda$processFor$8(Driver.java:283) at io.prestosql.operator.Driver.tryWithLock(Driver.java:675) at io.prestosql.operator.Driver.processFor(Driver.java:276) at io.prestosql.execution.SqlTaskExecution$DriverSplitRunner.processFor(SqlTaskExecution.java:1075) at io.prestosql.execution.executor.PrioritizedSplitRunner.process(PrioritizedSplitRunner.java:163) at io.prestosql.execution.executor.TaskExecutor$TaskRunner.run(TaskExecutor.java:484) at io.prestosql.$gen.Presto_332__testversion____20210221_151218_2.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) ``` ### Modifications 1. Retain the original buffer for RawMessage metadata peek since we reuse the data buffer to get the schema version etc. 2. Release the original data buffer while deallocating the `ReferenceCountedMessageMetadata.java` ### Verifying this change Unit test added. Integration test added. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (no) - The public API: (no) - The schema: (no) - The default values of configurations: (no) - The wire protocol: (no) - The rest endpoints: (no) - The admin cli options: (no) - Anything that affects deployment: (no) ### Documentation - Does this pull request introduce a new feature? (no)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the master branch, If enable data compression, Pulsar SQL will occurs following errors:
Modifications
ReferenceCountedMessageMetadata.javaVerifying this change
Unit test added.
Integration test added.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation