DISPATCH-2029: Added a base class and moved some of the http1 adaptor…

[ganeshmurthy]

… tests to this base class. Also introduced a new test that executes http1 tests over tcp

[codecov-io]

Codecov Report

Merging #1097 (09a06ed) into main (f2e205c) will increase coverage by 1.99%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1097      +/-   ##
==========================================
+ Coverage   82.29%   84.28%   +1.99%     
==========================================
  Files         111      111              
  Lines       27540    27540              
==========================================
+ Hits        22663    23213     +550     
+ Misses       4877     4327     -550     

Impacted Files	Coverage Δ
src/adaptors/http1/http1_server.c	84.59% <0.00%> (-0.30%)	⬇️
src/adaptors/http1/http1_codec.c	85.15% <0.00%> (-0.13%)	⬇️
src/router_node.c	93.59% <0.00%> (-0.11%)	⬇️
src/server.c	86.76% <0.00%> (+0.10%)	⬆️
src/message.c	86.67% <0.00%> (+0.28%)	⬆️
src/router_core/router_core.c	86.73% <0.00%> (+0.34%)	⬆️
src/router_core/connections.c	89.93% <0.00%> (+1.29%)	⬆️
src/router_core/transfer.c	94.39% <0.00%> (+1.72%)	⬆️
src/adaptors/tcp_adaptor.c	69.14% <0.00%> (+66.24%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2e205c...09a06ed. Read the comment docs.

[kgiusti]

Why is this broken up into two classes: Http1OneRouterTestBase and CommonHttp1AdaptorOneRouterTest? Since they must be inherited from together why not just combine them into a single class?

[ganeshmurthy]

The CommonHttp1AdaptorOneRouterTest contains only the tests, it does not have any setup information. In the future, this separation enables the the battery of tests in CommonHttp1AdaptorOneRouterTest to be run against a totally different setup

[kgiusti]

I'm good with this once Jiri's request has been added.