Skip to content
This repository was archived by the owner on Apr 15, 2026. It is now read-only.

DISPATCH-413 Reference the AMQP Management spec in docs in a less ambiguous manner#1358

Merged
jiridanek merged 1 commit into
apache:mainfrom
jiridanek:jd_2021_08_29_DISPATCH-413
Sep 3, 2021
Merged

DISPATCH-413 Reference the AMQP Management spec in docs in a less ambiguous manner#1358
jiridanek merged 1 commit into
apache:mainfrom
jiridanek:jd_2021_08_29_DISPATCH-413

Conversation

@jiridanek
Copy link
Copy Markdown
Contributor

@jiridanek jiridanek commented Aug 29, 2021

The spec in question is AMQP Management v1.0 WD09. I managed to find a newer working draft WD12 of the spec, but I did not manage to download a readable copy of it. It looks like the spec never got past working drafts anyways.

CC @pwright

@jiridanek jiridanek requested a review from rgodfrey August 29, 2021 09:59
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #1358 (ebd4ae8) into main (cdb51f9) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1358      +/-   ##
==========================================
- Coverage   84.76%   84.62%   -0.15%     
==========================================
  Files         114      114              
  Lines       28403    28404       +1     
==========================================
- Hits        24077    24038      -39     
- Misses       4326     4366      +40     
Impacted Files Coverage Δ
src/iterator.c 89.29% <0.00%> (-4.05%) ⬇️
src/router_core/connections.c 89.47% <0.00%> (-1.28%) ⬇️
src/router_core/delivery.c 93.34% <0.00%> (-0.74%) ⬇️
src/router_core/route_tables.c 82.70% <0.00%> (-0.58%) ⬇️
src/router_core/router_core.c 86.52% <0.00%> (-0.48%) ⬇️
src/message.c 87.35% <0.00%> (-0.14%) ⬇️
src/router_node.c 93.55% <0.00%> (+0.09%) ⬆️
src/adaptors/http1/http1_server.c 85.71% <0.00%> (+0.28%) ⬆️
src/router_core/transfer.c 94.39% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdb51f9...ebd4ae8. Read the comment docs.

@pwright
Copy link
Copy Markdown
Contributor

pwright commented Aug 30, 2021

@jiridanek
Copy link
Copy Markdown
Contributor Author

This is not part of AMQP 1.0 spec. It is some kind of extension on top, if I understand the situation correctly.

@jiridanek jiridanek merged commit c4bf544 into apache:main Sep 3, 2021
@jiridanek jiridanek deleted the jd_2021_08_29_DISPATCH-413 branch September 3, 2021 10:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants