Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cmake to use modern feature #288

Closed

Conversation

Projects
None yet
3 participants
@matlo607
Copy link

commented Apr 18, 2018

I wanted to create a recipe for Conan and I experienced some issue with the build system.

@ted-ross
Copy link
Member

left a comment

I greatly appreciate the work you've put into this submission. The problem is that we have several downstream distributions like RHEL7 that have cmake 2.8 and won't be able to build with this update.

@ted-ross

This comment has been minimized.

Copy link
Member

commented Jan 24, 2019

@matlo607 Can you please close this pull request? It is not going to be merged.
Thanks,
-Ted

if (UNIX)
set (QPID_DISPATCH_LIB "libqpid-dispatch.so")
else()
set (QPID_DISPATCH_LIB "qpid-dispatch.dll")

This comment has been minimized.

Copy link
@jdanekrh

jdanekrh Feb 17, 2019

Contributor

@matlo607 Did you actually managed to get useful binary of qdrouterd on Windows? I thought it won't compile on Windows.

This comment has been minimized.

Copy link
@matlo607

matlo607 Feb 22, 2019

Author

No, I only built it on Linux.
This work was a draft and has never been finalized.
I was expecting a more enthusiast review than the first comment I got.
That's a pity that the project wants to stick to completely outdated cmake versions only because it is installed by default on a distribution.

This comment has been minimized.

Copy link
@jdanekrh

jdanekrh Feb 22, 2019

Contributor

@matlo607 What is the crucial part of the PR that was necessary for your conan package? I'd be interested in trying to get that working, even given the restriction to CMake 2.8.12. Conan seems like a really helpful tool.

@matlo607 matlo607 closed this Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.