New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REEF-585] Add Mariia to committers list on website #365

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@dafrista
Contributor

dafrista commented Aug 12, 2015

Add Maria, and fix a typo on team page.

JIRA:
REEF-585

Pull Request:
This closes #

[REEF-585] Add Mariia to committers list on website
  Add Maria, and fix a typo on team page.

JIRA:
  [REEF-585](https://issues.apache.org/jira/browse/REEF-585)

Pull Request:
  This closes #
@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot Aug 12, 2015

Reef-pull-request-ubuntu #303 FAILURE
Looks like there's a problem with this pull request

asfbot commented Aug 12, 2015

Reef-pull-request-ubuntu #303 FAILURE
Looks like there's a problem with this pull request

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot Aug 12, 2015

REEF-pull-request-windows3 #206 SUCCESS
This pull request looks good

asfbot commented Aug 12, 2015

REEF-pull-request-windows3 #206 SUCCESS
This pull request looks good

@tcNickolas

This comment has been minimized.

Show comment
Hide comment
@tcNickolas

tcNickolas Aug 12, 2015

Member

I will merge

Member

tcNickolas commented Aug 12, 2015

I will merge

@markusweimer

This comment has been minimized.

Show comment
Hide comment
@markusweimer

markusweimer Aug 12, 2015

Contributor

@tcNickolas Ironically, you might not be able to. Do you have write-access to the GIT and SVN repos yet? The site needs to be published into the SVN repo.

Contributor

markusweimer commented Aug 12, 2015

@tcNickolas Ironically, you might not be able to. Do you have write-access to the GIT and SVN repos yet? The site needs to be published into the SVN repo.

@tcNickolas

This comment has been minimized.

Show comment
Hide comment
@tcNickolas

tcNickolas Aug 12, 2015

Member

This change doesn't look like the one which actually grants the access. So I should be able to merge it once I have the access (which I need to check, I haven't tried yet). So it's a perfect change to confirm that I have access to both

Member

tcNickolas commented Aug 12, 2015

This change doesn't look like the one which actually grants the access. So I should be able to merge it once I have the access (which I need to check, I haven't tried yet). So it's a perfect change to confirm that I have access to both

@markusweimer

This comment has been minimized.

Show comment
Hide comment
@markusweimer

markusweimer Aug 12, 2015

Contributor

@tcNickolas OK, makes sense.

Contributor

markusweimer commented Aug 12, 2015

@tcNickolas OK, makes sense.

@tcNickolas

This comment has been minimized.

Show comment
Hide comment
@tcNickolas

tcNickolas Aug 12, 2015

Member

I'm trying to generate the site and see the change, and it fails. I've done
git branch -b REEF-585
git pull apache master
git pull https://github.com/dafrista/incubator-reef REEF-585
mvn clean site:site

The last step fails
[WARNING] Unable to create Maven project for org.apache.reef:tang:pom:0.13.0-incubating-SNAPSHOT from repository.
org.apache.maven.project.ProjectBuildingException: Error resolving project artifact: Failure to find org.apache.reef:tang:pom:0.13.0-incubating-SNAPSHOT in http://repository.apache.org/snapshots was cached in the local repository, resolution will not be reattempted until the update interval of apache.snapshots has elapsed or updates are forced for project org.apache.reef:tang:pom:0.13.0-incubating-SNAPSHOT

I've tried doing mvn clean site:site for code from apache/incubator-reef, and it fails with the same error. @dafrista Does mvn clean site:site work for you for this change?

Member

tcNickolas commented Aug 12, 2015

I'm trying to generate the site and see the change, and it fails. I've done
git branch -b REEF-585
git pull apache master
git pull https://github.com/dafrista/incubator-reef REEF-585
mvn clean site:site

The last step fails
[WARNING] Unable to create Maven project for org.apache.reef:tang:pom:0.13.0-incubating-SNAPSHOT from repository.
org.apache.maven.project.ProjectBuildingException: Error resolving project artifact: Failure to find org.apache.reef:tang:pom:0.13.0-incubating-SNAPSHOT in http://repository.apache.org/snapshots was cached in the local repository, resolution will not be reattempted until the update interval of apache.snapshots has elapsed or updates are forced for project org.apache.reef:tang:pom:0.13.0-incubating-SNAPSHOT

I've tried doing mvn clean site:site for code from apache/incubator-reef, and it fails with the same error. @dafrista Does mvn clean site:site work for you for this change?

@dafrista

This comment has been minimized.

Show comment
Hide comment
@dafrista

dafrista Aug 13, 2015

Contributor

@tcNickolas I do see the warning, but the page in question is updated successfully. Did you run mvn clean site:site from website/? Then you should find the updated page at ./target/staging/site/team.html.

Contributor

dafrista commented Aug 13, 2015

@tcNickolas I do see the warning, but the page in question is updated successfully. Did you run mvn clean site:site from website/? Then you should find the updated page at ./target/staging/site/team.html.

@jsjason

This comment has been minimized.

Show comment
Hide comment
@jsjason

jsjason Aug 13, 2015

Contributor

Hi, the warning @tcNickolas posted is probably because of the lines

<dependency>
    <groupId>${project.groupId}</groupId>
    <artifactId>tang</artifactId>
    <version>${project.version}</version>
</dependency>

<dependency>
    <groupId>${project.groupId}</groupId>
    <artifactId>wake</artifactId>
    <version>${project.version}</version>
</dependency>

<dependency>
    <groupId>${project.groupId}</groupId>
    <artifactId>test-jar</artifactId>
    <version>${project.version}</version>
    <classifier>tests</classifier>
</dependency>

in $REEF_HOME/pom.xml (around line 374). They don't break the build, though.

Contributor

jsjason commented Aug 13, 2015

Hi, the warning @tcNickolas posted is probably because of the lines

<dependency>
    <groupId>${project.groupId}</groupId>
    <artifactId>tang</artifactId>
    <version>${project.version}</version>
</dependency>

<dependency>
    <groupId>${project.groupId}</groupId>
    <artifactId>wake</artifactId>
    <version>${project.version}</version>
</dependency>

<dependency>
    <groupId>${project.groupId}</groupId>
    <artifactId>test-jar</artifactId>
    <version>${project.version}</version>
    <classifier>tests</classifier>
</dependency>

in $REEF_HOME/pom.xml (around line 374). They don't break the build, though.

@jsjason

This comment has been minimized.

Show comment
Hide comment
@jsjason

jsjason Aug 13, 2015

Contributor

The "build" I just said refers to the website generation, not the project build.

Contributor

jsjason commented Aug 13, 2015

The "build" I just said refers to the website generation, not the project build.

@tcNickolas

This comment has been minimized.

Show comment
Hide comment
@tcNickolas

tcNickolas Aug 13, 2015

Member

My bad, was looking for the updated pages in the wrong site folder (website/target/site/ one). The change looks good.

What is the next step - publish the site first, commit to git second? And what is our guideline for log message for svn - REEF issue # and JIRA title, like in http://svn.apache.org/viewvc?view=revision&revision=1695227 ?

Member

tcNickolas commented Aug 13, 2015

My bad, was looking for the updated pages in the wrong site folder (website/target/site/ one). The change looks good.

What is the next step - publish the site first, commit to git second? And what is our guideline for log message for svn - REEF issue # and JIRA title, like in http://svn.apache.org/viewvc?view=revision&revision=1695227 ?

@asfgit asfgit closed this in 338d87c Aug 14, 2015

@dafrista

This comment has been minimized.

Show comment
Hide comment
@dafrista

dafrista Aug 15, 2015

Contributor

AFAIK, we don't have a policy for either.
What I've done personally is commit to git first, publish site second. For the log message, the SVN log will be seen by all incubator projects, so clearly denote that this is a REEF related change.

Contributor

dafrista commented Aug 15, 2015

AFAIK, we don't have a policy for either.
What I've done personally is commit to git first, publish site second. For the log message, the SVN log will be seen by all incubator projects, so clearly denote that this is a REEF related change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment