[ISSUE #21] Distinguish between brokerName and brokerClusterName #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuruiyiyang
reviewed
Apr 1, 2020
There was a problem hiding this comment.
Seems this PR is related to PR#24, why split this PR from it? If just change the env BROKER_CLUSTER_NAME to the same broker name in different broker groups, it is not compatible with other designs like the scale up process and thus causes some issue, since the brokerClusterName here is refer to the broker group name.
|
@liuruiyiyang the env BROKER_CLUSTER_NAME seems to only be used to generate configuration files and will not affect the scale up process which obtaining metadata through scalePodName. Also I have tested the function is normal. |
|
LGTM |
vongosling
approved these changes
Jul 22, 2020
zhihui921016
added a commit
to zhihui921016/rocketmq-operator
that referenced
this pull request
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brokerClusterName removes the brokerGroupIndex suffix