From 13138560b2d991ec16ebd28a2720025d6903e70a Mon Sep 17 00:00:00 2001 From: odbozhou <877036922@qq.com> Date: Sat, 15 Dec 2018 11:59:39 +0800 Subject: [PATCH] Fixed this issure https://github.com/apache/rocketmq-spring/issues/10 --- .../DefaultRocketMQListenerContainer.java | 8 ++- .../DefaultRocketMQListenerContainerTest.java | 61 +++++++++++++++++++ 2 files changed, 68 insertions(+), 1 deletion(-) create mode 100644 rocketmq-spring-boot/src/test/java/org/apache/rocketmq/spring/support/DefaultRocketMQListenerContainerTest.java diff --git a/rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/support/DefaultRocketMQListenerContainer.java b/rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/support/DefaultRocketMQListenerContainer.java index 19930357..ce1b388e 100644 --- a/rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/support/DefaultRocketMQListenerContainer.java +++ b/rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/support/DefaultRocketMQListenerContainer.java @@ -348,7 +348,13 @@ private Object doConvertMessage(MessageExt messageExt) { } private Class getMessageType() { - Type[] interfaces = AopUtils.getTargetClass(rocketMQListener).getGenericInterfaces(); + Class targetClass = AopUtils.getTargetClass(rocketMQListener); + Type[] interfaces = targetClass.getGenericInterfaces(); + Class superclass = targetClass.getSuperclass(); + while ((Objects.isNull(interfaces) || 0 == interfaces.length) && Objects.nonNull(superclass)) { + interfaces = superclass.getGenericInterfaces(); + superclass = targetClass.getSuperclass(); + } if (Objects.nonNull(interfaces)) { for (Type type : interfaces) { if (type instanceof ParameterizedType) { diff --git a/rocketmq-spring-boot/src/test/java/org/apache/rocketmq/spring/support/DefaultRocketMQListenerContainerTest.java b/rocketmq-spring-boot/src/test/java/org/apache/rocketmq/spring/support/DefaultRocketMQListenerContainerTest.java new file mode 100644 index 00000000..57876890 --- /dev/null +++ b/rocketmq-spring-boot/src/test/java/org/apache/rocketmq/spring/support/DefaultRocketMQListenerContainerTest.java @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.rocketmq.spring.support; +import org.apache.rocketmq.common.message.MessageExt; +import org.apache.rocketmq.spring.core.RocketMQListener; +import org.junit.Test; +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Method; +import static org.assertj.core.api.Assertions.assertThat; +public class DefaultRocketMQListenerContainerTest { + @Test + public void testGetMessageType() throws NoSuchMethodException { + DefaultRocketMQListenerContainer listenerContainer = new DefaultRocketMQListenerContainer(); + Method getMessageType = DefaultRocketMQListenerContainer.class.getDeclaredMethod("getMessageType"); + getMessageType.setAccessible(true); + try { + listenerContainer.setRocketMQListener(new BaseStringConsumer()); + Class result = (Class) getMessageType.invoke(listenerContainer); + assertThat(result.getName().equals(String.class.getName())).isTrue(); + listenerContainer.setRocketMQListener(new BaseMessageExtConsumer()); + result = (Class) getMessageType.invoke(listenerContainer); + assertThat(result.getName().equals(MessageExt.class.getName())).isTrue(); + listenerContainer.setRocketMQListener(new ConcreteStringConsumer()); + result = (Class) getMessageType.invoke(listenerContainer); + assertThat(result.getName().equals(String.class.getName())).isTrue(); + listenerContainer.setRocketMQListener(new ConcreteMessageExtConsumer()); + result = (Class) getMessageType.invoke(listenerContainer); + assertThat(result.getName().equals(MessageExt.class.getName())).isTrue(); + } catch (IllegalAccessException | InvocationTargetException e) { + e.printStackTrace(); + } + } +} +class BaseStringConsumer implements RocketMQListener { + @Override + public void onMessage(String message) { + } +} +class ConcreteStringConsumer extends BaseStringConsumer { +} +class BaseMessageExtConsumer implements RocketMQListener { + @Override + public void onMessage(MessageExt message) { + } +} +class ConcreteMessageExtConsumer extends BaseMessageExtConsumer { +} \ No newline at end of file