From e07754f2ab4c637e9acbc1452de03375c4867dce Mon Sep 17 00:00:00 2001 From: RongtongJin Date: Mon, 12 Jun 2023 16:28:42 +0800 Subject: [PATCH] Fix incorrect naming in update configuration protection --- .../rocketmq/namesrv/processor/DefaultRequestProcessor.java | 2 +- .../rocketmq/namesrv/processor/DefaultRequestProcessorTest.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java b/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java index 0efef1b52c3..e679dcafbca 100644 --- a/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java +++ b/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java @@ -581,7 +581,7 @@ private RemotingCommand updateConfig(ChannelHandlerContext ctx, RemotingCommand return response; } - if (properties.containsKey("kvConfigPath") || properties.containsKey("configStorePathName")) { + if (properties.containsKey("kvConfigPath") || properties.containsKey("configStorePath")) { response.setCode(ResponseCode.NO_PERMISSION); response.setRemark("Can not update config path"); return response; diff --git a/namesrv/src/test/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessorTest.java b/namesrv/src/test/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessorTest.java index 329fe53fe10..f22031ea6ea 100644 --- a/namesrv/src/test/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessorTest.java +++ b/namesrv/src/test/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessorTest.java @@ -178,7 +178,7 @@ public void testProcessRequest_UpdateConfigPath() throws RemotingCommandExceptio //update disallowed value properties.clear(); - properties.setProperty("configStorePathName", "test/path"); + properties.setProperty("configStorePath", "test/path"); updateConfigRequest.setBody(MixAll.properties2String(properties).getBytes(StandardCharsets.UTF_8)); response = defaultRequestProcessor.processRequest(null, updateConfigRequest);