Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master node route info was lost when some node restarted and joined the group in dledger mode #1464

Closed
RongtongJin opened this issue Sep 19, 2019 · 1 comment
Labels
Milestone

Comments

@RongtongJin
Copy link
Contributor

@RongtongJin RongtongJin commented Sep 19, 2019

BUG REPORT

  1. Please describe the issue you observed:
  • What did you do (The steps to reproduce)?

when I running rocketmq on dledger with jepsen test, I found master node route info was lost when a node restarted and joined the group. It caused the service to be unavailable for a period of time until master re-registered with nameserver.

  • What did you expect to see?

When node restart and join the group, the service is still available.

  1. Please tell us about your environment:

centos 7

  1. Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc):

Since brokerId defaults to 0,

private long brokerId = MixAll.MASTER_ID;

when broker restart, it will register with namserver before brokerId is changed(when dledger role is changed),

this.registerBrokerAll(true, false, true);

causing the route info of master to be overwritten.

@duhenglucky duhenglucky added this to the 4.6.0 milestone Sep 20, 2019
@duhenglucky duhenglucky added the bug label Sep 20, 2019
RongtongJin added a commit to RongtongJin/rocketmq that referenced this issue Sep 20, 2019
…me node join the group in dledger mode

Since brokerId defaults to 0, it will register with nameserver before brokerId is changed when broker restart, causing the route info of master to be overwritten.
Set brokerId defaults to -1 in dledger mode and do not register wtih nameserver until brokerId is changed.

Close apache#1464
duhenglucky added a commit that referenced this issue Oct 24, 2019
[ISSUE #1464] Fix the issue that master node route info was lost when the node joined the group in dledger mode
@duhenglucky

This comment has been minimized.

Copy link
Contributor

@duhenglucky duhenglucky commented Oct 24, 2019

fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.