Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RocketMQ spring will throw IllegalStateException when the spring application is closed #1491

Closed
RongtongJin opened this issue Sep 27, 2019 · 0 comments
Labels
bug
Milestone

Comments

@RongtongJin
Copy link
Contributor

@RongtongJin RongtongJin commented Sep 27, 2019

BUG REPORT

  1. Please describe the issue you observed:
    RocketMQ spring will throw IllegalStateException when the spring application is closed
    refer rocketmq-spring issue136.
  2. Please tell us about your environment:
    Mac OS
  3. Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc):
    When producer invoke shutdown, shutdownhook of AsyncTraceDispatcher is removed.
    In RocketMQ spring, shutdown method of producer is invoked when the application is closed. While JVM is closing, and shutdown hook is removed at the same time, which causes IllegalStateException to be thrown.
RongtongJin added a commit to RongtongJin/rocketmq that referenced this issue Sep 27, 2019
If shutdown of the JVM in progress already, we don't need to remove the hook, it will be removed by the JVM.

Close apache#1491
@vongosling vongosling added this to the 4.6.0 milestone Sep 28, 2019
@vongosling vongosling added the bug label Sep 28, 2019
@vongosling vongosling closed this Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.