Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some typo in docs/cn/design.md #1503

Closed
Switch-vov opened this issue Oct 1, 2019 · 1 comment
Labels
bug
Milestone

Comments

@Switch-vov
Copy link
Contributor

@Switch-vov Switch-vov commented Oct 1, 2019

BUG REPORT
As title, there're some typo in docs/cn/design.md.

RocketMQ消息队列集群主要包括NameServe、Broker in 2 通信机制. It should be updated to NameServer.

相当于reqeustId,在同一个连接上 in 2.2 协议设计与编解码. It should be updated to requestId.

RocketMQ这么做是还是在于其Producer端写入消息和Consomer端订阅消息采用分离存储的机制来实现的
in 3 消息过滤. I suggest it should be updated to 这么做是在于 and Consumer.

That's all.

Switch-vov added a commit to Switch-vov/rocketmq that referenced this issue Oct 1, 2019
@Switch-vov Switch-vov changed the title A typo in docs/cn/design.md Some typo in docs/cn/design.md Oct 1, 2019
Switch-vov added a commit to Switch-vov/rocketmq that referenced this issue Oct 1, 2019
Switch-vov added a commit to Switch-vov/rocketmq that referenced this issue Oct 1, 2019
@Switch-vov

This comment has been minimized.

Copy link
Contributor Author

@Switch-vov Switch-vov commented Oct 1, 2019

@duhenglucky please review it.

duhenglucky added a commit that referenced this issue Oct 4, 2019
[ISSUES #1503] fix some typo in docs/cn/design.md
@duhenglucky duhenglucky added this to the 4.6.0 milestone Oct 4, 2019
@duhenglucky duhenglucky added the bug label Oct 4, 2019
@duhenglucky duhenglucky closed this Oct 4, 2019
tandanzZ pushed a commit to tandanzZ/rocketmq that referenced this issue Oct 23, 2019
* ORIGN-develop: (97 commits)
  correct spelling mistakes
  check transferOK to reduce unnecessary wait
  [apache#1540] format checkstyle
  [apache#1540] format checkstyle
  [apache#1540] remove test
  [apache#1540] add comment
  [apache#1540] 4.5.2版本 事务消息设置延迟时间后导致RMQ_SYS_TRANS_HALF_TOPIC爆掉的问题修复
  fix ha sync transfer timeout
  fix(test) fix the MessageClientIDSetterTest unit test
  fix(remoting) upgrade fastjson to 1.2.61
  polish codes for updateTopicPermSubCommand.
  docs(README): address core feature description
  fix some typo in docs/cn/design.md (apache#1503)
  GetAccessConfigSubCommand for ACL configuration (apache#1263)
  GetAccessConfigSubCommand for ACL configuration (apache#1263)
  fix(trace):ignore IllegalStateException when remove shutdown hook
  [ISSUE apache#1483] fix bug in QueryMsgByIdSubCommand print OffsetID twice
  Fix(client):fix the issue that lite pull consumer lost messages in some scenario
  Update Configuration_Client.md
  docs(operation.md): remove discarded mqadmin command description
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.